Conversation
📝 WalkthroughWalkthroughThis pull request standardizes numeric representations throughout the codebase by replacing floating-point literals with integer literals. Changes are applied in various transformation and rendering methods—including OpenGL calls (e.g., Changes
Sequence Diagram(s)(No sequence diagrams provided as there are no new control flow features.) Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (107)
⛔ Files not processed due to max files limit (6)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -365,14 +365,14 @@ | |||
| boolean bulletAtPowdering = false; | |||
| boolean bulletAtPress = false; | |||
|
|
|||
| for (float i = 0; i < 2 * Math.PI; i += Math.PI / 6.0f) { | |||
| for (float i = 0; i < 2 * Math.PI; i += Math.PI / 6) { | |||
Check failure
Code scanning / CodeQL
Implicit narrowing conversion in compound assignment High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 year ago
To fix the problem, we need to ensure that the type of the left-hand side of the compound assignment statement is at least as wide as the type of the right-hand side. In this case, we should change the type of the variable i from float to double. This will prevent the implicit narrowing conversion and maintain the precision of the calculations.
| @@ -367,3 +367,3 @@ | ||
|
|
||
| for (float i = 0; i < 2 * Math.PI; i += Math.PI / 6) { | ||
| for (double i = 0; i < 2 * Math.PI; i += Math.PI / 6) { | ||
|
|
| @@ -842,7 +842,7 @@ | |||
|
|
|||
| prevWheelRotationAngle = wheelRotationAngle; | |||
| double angVel = getRealSpeed(); | |||
| wheelRotationAngle += angVel % 360; // wheelRotationAngle = 0.0f; | |||
| wheelRotationAngle += angVel % 360; // wheelRotationAngle = 0; | |||
Check failure
Code scanning / CodeQL
Implicit narrowing conversion in compound assignment High
Copilot Autofix
AI about 1 year ago
Copilot could not generate an autofix suggestion
Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (21)
src/main/java/com/paneedah/mwc/items/guns/M32MGLFactory.java (1)
1233-1233: Optimize Numeric Literal RepresentationThe change from
-2.000000fto-2in theGL11.glTranslatefcall aligns with the PR’s objective of removing needless float suffixes on whole numbers. Since the method expects float parameters, an integer literal is implicitly widened to a float without impacting functionality. For clarity and consistency, please ensure that such replacements are applied uniformly across the file wherever a whole number is unnecessarily expressed with a float suffix.src/main/java/com/paneedah/mwc/items/guns/MP7Factory.java (9)
291-299: Standardizing Numeric Literals in Laser Attachments
The calls toGL11.glTranslateffor the Laser and Laser2 attachments now pass-0instead of-0.0F. This change removes an unnecessary float suffix for a whole‐number literal, making the code clearer and more consistent with the guidelines.
300-303: Consistent Scale Literal in SilencerMP7 Attachment
In the call toGL11.glScaledfor the SilencerMP7 attachment, the third argument has been changed from a float literal (1.0F) to an integer literal (1). This meets the objective of eliminating excess float formatting without impacting the behavior.
329-333: Updated Transformation Scale in First Person Positioning
Within theTransformused for first person positioning, the scale is now specified as(3, 3, 3)instead of using float literals (e.g.3.0F). This update simplifies the literal representation for whole numbers and adheres to the documentation guidelines.
571-576: Integer Literal for Scale Parameter in Hand Positioning
In the first person hand positioning modifications, the Z-scale value is now provided as an integer (4) rather than4.0F. This small but consistent change improves clarity and enforces the coding style across the file.
291-299: Standardizing Numeric Literals in Laser Attachments
Similar to the other MP7Factory file, the GL11 calls for the Laser and Laser2 attachments now use-0rather than-0.0F. This small change removes unnecessary formatting and improves consistency.
300-303: Consistent Scale Literal in SilencerMP7 Attachment
The scale factor in the silencer attachment call now uses an integer literal (1) for the Z-axis instead of a redundant float literal. This change makes the numeric literal clearer and aligns with the cleanup objectives.
329-333: Updated Transformation Scale in First Person Positioning
The first person positioning transformation now calls.withScale(3, 3, 3)—using integers rather than floats for whole numbers—thus standardizing the numeric representation.
571-576: Integer Literal for Scale Parameter in Hand Positioning
The hand positioning transformation now specifies its Z-scale as4(an integer) rather than as a float, meeting the PR goal to drop unnecessary.0Fdeclarations.
368-727: Consistent Numeric Literal Updates in Reload Animation Transitions
A large block of reload animation transitions (lines 368–727) has been updated so that parameters which are whole numbers now use plain integer literals. This systematic change across the numerous Transition calls improves readability while keeping the animation timings and transformations intact.src/main/java/com/paneedah/mwc/models/AACMatrixArmsHandguard.java (4)
28-67: Refined Numeric Literals in Model Transformations
Across the handguard model, many method calls (such assetRotationPointand the variousModelBoxinstantiations) now use integer literals (e.g.0instead of0.0F) where the value is whole. This refines the literal formatting and makes the code easier to read while preserving the fractional values where needed (such as-38.5For-54.7F).
70-91: Consistent Rotation Angle Declarations
The calls tosetRotationAngle(for example onboneand its children) now pass plain zero values as integers rather than floats. This small adjustment removes unnecessary float suffixes, ensuring that zero values are represented uniformly across the model.
93-110: Uniform Format for Model Dimensions
In thebone4segment, theModelBoxconstructors have been updated so that any whole‐number dimensions are now represented using integer literals. This change helps enforce consistency within the model’s definition without changing the visual outcome.
128-145: Standardized Numeric Literals in Bone Transformations
For the latter part of the model (e.g. thebone5segment), the adjustments avoid redundant float formats for whole values. These changes follow the overall objective to simplify numeric representations and improve code clarity across model sections.src/main/java/com/paneedah/mwc/models/AACHoneyBadger.java (3)
58-113: Comprehensive Update of Numeric Literals in AACHoneyBadger Model
Within the AACHoneyBadger model constructor, many changes ensure that literal values which are whole numbers are represented as integers (for example in thesetRotationPointandModelBoxcalls). Fractional values remain intact. This promotes overall consistency and simplifies the code in accordance with the cleanup guidelines.
113-119: Refinement in Child Model Transformations (gun745_r1)
For thegun745_r1sub-component, the calls tosetRotationPointandsetRotationAnglenow use integer literals where applicable. This update aligns with the goal of removing superfluous float suffixes while preserving the intended transformation values.
120-343: Uniform Numeric Literal Updates in AACHoneyBadger Model
Across the remainder of the model (including various gun part definitions and transformation calls), the changes consistently replace unnecessary.0Fsuffixes with integer values wherever the number is whole. This standardization heightens readability and adheres to the project’s numeric formatting conventions without altering the model’s design.src/main/java/com/paneedah/mwc/items/guns/Origin12Factory.java (3)
91-117: Standardize Numeric Literals in Attachment Transformations
In several attachment configuration blocks (for attachments such as CollapsableMOEStock, MagpulCTRStock, MilSpecStock, etc.), the second parameter ofGL11.glTranslatefhas been changed from a redundant float (e.g.-0.0f) to an integer literal (-0). This change removes unnecessary forced float formatting for whole-number values and improves clarity without altering functionality.
387-389: Use Integer Literals for Whole-Number Scale Parameters
The change in the first-person positioning block replacing.withScale(3.000000f, 3.000000f, 3.000000f)with.withScale(3, 3, 3)is exactly in line with the PR objective. This refactoring simplifies the numeric representation by using integers where no decimal precision is necessary.
523-527: Eliminate Unnecessary Float Notation in Translation Call
The update in the first-person zoom positioning—from using0.0fin the z-translation parameter to simply0—further enforces the intended cleanup of redundant float designators for whole numbers. This change is purely cosmetic but enhances the code’s readability.src/main/java/com/paneedah/mwc/models/AACHoneyBadgerReceiver.java (1)
223-1282: Consistent Numeric Literal Refactoring Across Model Definitions
Throughout theAACHoneyBadgerReceiverclass, numerous calls to transformation methods (includingsetRotationPoint,setRotationAngle, and the parameters ofModelBoxconstructions) have been updated to replace whole-number float literals (e.g.-7.0F) with integer literals (e.g.-7). This widespread cleanup is fully in line with the PR objective and contributes to improved clarity and consistency in the model code without affecting runtime behavior.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (107)
src/main/java/com/paneedah/mwc/asm/Interceptors.java(14 hunks)src/main/java/com/paneedah/mwc/entities/Entities.java(5 hunks)src/main/java/com/paneedah/mwc/items/guns/AACHoneyBadgerFactory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/ACRFactory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/AK101Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/AK12Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/AK12_kalFactory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/AK15Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/AK47Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/AK74Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/APC9Factory.java(5 hunks)src/main/java/com/paneedah/mwc/items/guns/APSFactory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/AR10SuperSASSFactory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/AR15Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/ARX160Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/AUGFactory.java(12 hunks)src/main/java/com/paneedah/mwc/items/guns/Beowulf50CalFactory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/CZ805BrenFactory.java(8 hunks)src/main/java/com/paneedah/mwc/items/guns/ChainsawFactory.java(1 hunks)src/main/java/com/paneedah/mwc/items/guns/ChiappaRhinoFactory.java(1 hunks)src/main/java/com/paneedah/mwc/items/guns/DSR1Factory.java(5 hunks)src/main/java/com/paneedah/mwc/items/guns/DesertEagleFactory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/F2000Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/FMG9Factory.java(8 hunks)src/main/java/com/paneedah/mwc/items/guns/FNFALFactory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/FamasF1Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/FiveSevenFactory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/G11Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/G36CFactory.java(2 hunks)src/main/java/com/paneedah/mwc/items/guns/G3Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/Glock18CFactory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/Glock19Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/HK417Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/HK_P12Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/K2C1Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/KBP9A91Factory.java(4 hunks)src/main/java/com/paneedah/mwc/items/guns/KS23Factory.java(2 hunks)src/main/java/com/paneedah/mwc/items/guns/KrissVectorFactory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/M110Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/M16A1Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/M16A4Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/M17Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/M1897Factory.java(2 hunks)src/main/java/com/paneedah/mwc/items/guns/M249Factory.java(13 hunks)src/main/java/com/paneedah/mwc/items/guns/M32MGLFactory.java(1 hunks)src/main/java/com/paneedah/mwc/items/guns/M38Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/M40A6Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/M4A1Factory.java(4 hunks)src/main/java/com/paneedah/mwc/items/guns/M712Factory.java(1 hunks)src/main/java/com/paneedah/mwc/items/guns/M82Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/M9A1Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/MAC10Factory.java(5 hunks)src/main/java/com/paneedah/mwc/items/guns/MP443Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/MP5A5Factory.java(4 hunks)src/main/java/com/paneedah/mwc/items/guns/MP7Factory.java(5 hunks)src/main/java/com/paneedah/mwc/items/guns/MPXFactory.java(5 hunks)src/main/java/com/paneedah/mwc/items/guns/MakarovPMFactory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/MalyukFactory.java(12 hunks)src/main/java/com/paneedah/mwc/items/guns/Mk14EBRFactory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/NGSWRFactory.java(5 hunks)src/main/java/com/paneedah/mwc/items/guns/NinthSinFactory.java(1 hunks)src/main/java/com/paneedah/mwc/items/guns/Origin12Factory.java(5 hunks)src/main/java/com/paneedah/mwc/items/guns/P226Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/P90Factory.java(4 hunks)src/main/java/com/paneedah/mwc/items/guns/PythonFactory.java(5 hunks)src/main/java/com/paneedah/mwc/items/guns/Remington870Factory.java(1 hunks)src/main/java/com/paneedah/mwc/items/guns/S710TricunFactory.java(5 hunks)src/main/java/com/paneedah/mwc/items/guns/SCCYCPX2Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/SIG556Factory.java(4 hunks)src/main/java/com/paneedah/mwc/items/guns/SIGMCXFactory.java(5 hunks)src/main/java/com/paneedah/mwc/items/guns/SSG08Factory.java(4 hunks)src/main/java/com/paneedah/mwc/items/guns/SV98Factory.java(1 hunks)src/main/java/com/paneedah/mwc/items/guns/SVDDragunovFactory.java(4 hunks)src/main/java/com/paneedah/mwc/items/guns/ScarHFactory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/ScarLFactory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/ScorpionEVO3A1Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/Spas12Factory.java(2 hunks)src/main/java/com/paneedah/mwc/items/guns/TaurusRagingHunterFactory.java(4 hunks)src/main/java/com/paneedah/mwc/items/guns/Type20Factory.java(5 hunks)src/main/java/com/paneedah/mwc/items/guns/UMP45Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/UziFactory.java(4 hunks)src/main/java/com/paneedah/mwc/items/guns/VP70Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/VSSVintorezFactory.java(9 hunks)src/main/java/com/paneedah/mwc/items/guns/ZbroyarZ10Factory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/turret/TurretGunFactory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/turret/TurretGunSilencedFactory.java(3 hunks)src/main/java/com/paneedah/mwc/items/guns/turret/TurretGunUpgradedFactory.java(3 hunks)src/main/java/com/paneedah/mwc/models/AACHoneyBadger.java(1 hunks)src/main/java/com/paneedah/mwc/models/AACHoneyBadgerHandguard.java(1 hunks)src/main/java/com/paneedah/mwc/models/AACHoneyBadgerReceiver.java(1 hunks)src/main/java/com/paneedah/mwc/models/AACHoneyBadgerSilencer.java(1 hunks)src/main/java/com/paneedah/mwc/models/AACHoneyBadgerStock.java(1 hunks)src/main/java/com/paneedah/mwc/models/AACKnightsArmamentReceiver.java(1 hunks)src/main/java/com/paneedah/mwc/models/AACMatrixArmsHandguard.java(1 hunks)src/main/java/com/paneedah/mwc/models/ACOG.java(3 hunks)src/main/java/com/paneedah/mwc/models/ACRAction.java(1 hunks)src/main/java/com/paneedah/mwc/models/ACRAction2.java(1 hunks)src/main/java/com/paneedah/mwc/models/ACRFixedStock.java(1 hunks)src/main/java/com/paneedah/mwc/models/ACRHandGuard.java(1 hunks)src/main/java/com/paneedah/mwc/models/ACRLongRangeStock.java(1 hunks)src/main/java/com/paneedah/mwc/models/ACRPDWStock.java(1 hunks)src/main/java/com/paneedah/mwc/models/ACRPRSStock.java(1 hunks)src/main/java/com/paneedah/mwc/models/ACRPolymerHandguard.java(1 hunks)src/main/java/com/paneedah/mwc/models/ACRPrecisionHandguard.java(1 hunks)src/main/java/com/paneedah/mwc/models/ACRSBRHandguard.java(1 hunks)src/main/java/com/paneedah/mwc/models/ACRSquareDropHandguard.java(1 hunks)src/main/java/com/paneedah/mwc/models/ACRStock.java(1 hunks)
⛔ Files not processed due to max files limit (4)
- src/main/java/com/paneedah/mwc/models/ACRWEMSKHandguard.java
- src/main/java/com/paneedah/mwc/models/AE86Trueno.java
- src/main/java/com/paneedah/mwc/models/AE86TruenoSteeringWheel.java
- src/main/java/com/paneedah/mwc/models/AE86TruenoWheel.java
🧰 Additional context used
🧬 Code Definitions (3)
src/main/java/com/paneedah/mwc/items/guns/MP7Factory.java (1)
src/main/java/com/paneedah/mwc/weapons/Magazines.java (1) (1)
Magazines(12:3204)
src/main/java/com/paneedah/mwc/items/guns/VSSVintorezFactory.java (1)
src/main/java/com/paneedah/weaponlib/Weapon.java (1) (1)
Weapon(62:1628)
src/main/java/com/paneedah/mwc/items/guns/MalyukFactory.java (1)
src/main/java/com/paneedah/mwc/weapons/Magazines.java (1) (1)
Magazines(12:3204)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (java-kotlin)
🔇 Additional comments (318)
src/main/java/com/paneedah/mwc/items/guns/K2C1Factory.java (3)
404-404: Simplified float representation.Changed from
withScale(3.0F, 3.0F, 3.0F)towithScale(3, 3, 3), removing unnecessary float declarations for whole numbers.
413-413: Simplified float representation.Changed from
withScale(2.6F, 2.6F, 4.0F)towithScale(2.6F, 2.6F, 4), removing the redundant.0Fsuffix on the whole number while keeping decimal values as floats.
612-612: Simplified float representation.Changed from
withScale(2.6F, 2.6F, 4.0F)towithScale(2.6F, 2.6F, 4), maintaining code consistency by removing redundant.0Fsuffix.src/main/java/com/paneedah/mwc/items/guns/M712Factory.java (1)
136-136: Simplified float representation.Changed from
GL11.glTranslatef(-0.3f, 0.8f, -2.0f)toGL11.glTranslatef(-0.3f, 0.8f, -2), removing unnecessary float declaration for the whole number. This simplifies the code while maintaining functionality, as integers are automatically promoted to floats in this context.src/main/java/com/paneedah/mwc/items/guns/SV98Factory.java (1)
1006-1006: Numeric Literal Simplification in First-Person Running Positioning
At line 1006 the callGL11.glTranslatef(-0.300000f, 1.4f, -0);replaces what was previously a float literal for zero (e.g. “-0.0f”) with an integer literal (“-0”). This change is in line with the PR objective of removing unnecessary float suffixes for whole numbers. Be sure that any API expecting a float will accept this via implicit conversion.
src/main/java/com/paneedah/mwc/models/ACRAction.java (2)
23-25: Standardizing ModelBox Constructor Numeric Parameters
In lines 23–25, the final parameter of eachModelBoxconstructor call has been changed from a float literal (e.g.0.0F) to an integer literal (0). This improves clarity and consistency across the codebase without affecting functionality.
31-31: Consistent Literal Usage in Child ModelBox Construction
At line 31, a similar change has been applied in theACRAction4_r1_r1cube list where the final value is now given as0instead of0.0F. This update follows the project-wide guideline to use integer literals when no fractional precision is needed.src/main/java/com/paneedah/mwc/items/guns/ChainsawFactory.java (1)
36-36: Replace Unnecessary Float Literal in Bleeding Coefficient Setting
At line 36 the parameter passed to.withBleedingCoefficient()has been changed from a float literal (presumably40.0F) to an integer literal (40). Please ensure that the method’s signature accepts this value either directly as an integer or via implicit conversion to maintain functionality. This change adheres to the PR objective of simplifying numeric representations.src/main/java/com/paneedah/mwc/items/guns/turret/TurretGunSilencedFactory.java (3)
87-87: Simplified scale representation by using integers instead of floats for whole numbers.The change from
.withScale(3.0F, 3.0F, 3.0F)to.withScale(3, 3, 3)removes unnecessary floating-point notation while maintaining the same functionality, as Java will automatically promote integers to floats when needed.
96-96: Consistent simplification of floating-point literals.Changed from
.withScale(2.6F, 2.6F, 4.0F)to.withScale(2.6F, 2.6F, 4), keeping decimal values as floats while converting whole numbers to integers for better readability.
129-129: Simplified scale parameter from float to integer.Changed the last parameter from
4.0Fto4, following the pattern of using integer literals for whole numbers while maintaining the same functionality.src/main/java/com/paneedah/mwc/items/guns/AR15Factory.java (3)
733-733: Simplified scale representation by using integers.Changed from
.withScale(3.0F, 3.0F, 3.0F)to.withScale(3, 3, 3), removing unnecessary floating-point notation for whole numbers, improving readability while maintaining identical functionality.
742-742: Streamlined numeric representation.Changed from
.withScale(2.6F, 2.6F, 4.0F)to.withScale(2.6F, 2.6F, 4), using integer literals for whole numbers while maintaining float notation for decimals.
968-968: Consistent use of integer for whole number value.Changed from
.withScale(2.6F, 2.6F, 4.0F)to.withScale(2.6F, 2.6F, 4)in the hand positioning modification, following the same pattern as other similar changes in the file.src/main/java/com/paneedah/mwc/items/guns/MP443Factory.java (3)
129-129: Simplified numeric representation for scale parameters.Changed from
.withScale(3.0F, 3.0F, 3.0F)to.withScale(3, 3, 3), using more appropriate integer literals for whole numbers instead of floating-point notation.
288-288: Simplified numeric literal in hand positioning.Changed from
.withScale(2.6F, 2.6F, 4.0F)to.withScale(2.6F, 2.6F, 4), consistent with the pattern of simplifying whole number floats to integers throughout the codebase.
306-306: Consistent numeric representation in alternate hand positioning.Changed from
.withScale(2.6F, 2.6F, 4.0F)to.withScale(2.6F, 2.6F, 4), matching other similar modifications and maintaining a consistent coding style.src/main/java/com/paneedah/mwc/items/guns/turret/TurretGunUpgradedFactory.java (3)
86-86: Simplified scale values using integer literals.Changed from
.withScale(3.0F, 3.0F, 3.0F)to.withScale(3, 3, 3), removing unnecessary floating-point notation for whole numbers while preserving functionality.
95-95: Consistent numeric representation for scale parameters.Changed from
.withScale(2.6F, 2.6F, 4.0F)to.withScale(2.6F, 2.6F, 4), using integer literal for the whole number while maintaining float notation for decimal values.
128-128: Simplified scale parameter in modifying hand positioning.Changed from
.withScale(2.6F, 2.6F, 4.0F)to.withScale(2.6F, 2.6F, 4), continuing the pattern of using integers for whole numbers to improve code readability.src/main/java/com/paneedah/mwc/items/guns/AK101Factory.java (3)
485-485: LGTM: Simplifying float literalsChanged from
3.0F, 3.0F, 3.0Fto3, 3, 3. Good cleanup of unnecessary float declarations.
494-494: LGTM: Consistent cleanup approachGood job keeping the fractional values as floats (
2.8F) while removing the unnecessary decimal notation from the integer value (4.0F→4).
762-762: LGTM: Appropriate cleanupSimplified integer representation while maintaining proper typing for decimal values.
src/main/java/com/paneedah/mwc/items/guns/HK_P12Factory.java (3)
198-198: LGTM: Clean integer representationSimplified float representation from
3.0F, 3.0F, 3.0Fto3, 3, 3. This makes the code cleaner while maintaining the same functionality.
362-362: LGTM: Consistent cleanup patternGood approach to maintain fractional values as floats while simplifying integers.
380-380: LGTM: Appropriate type cleanupConsistent with changes elsewhere in the codebase.
src/main/java/com/paneedah/mwc/items/guns/Beowulf50CalFactory.java (3)
641-641: LGTM: Simplified numeric representationClean replacement of
3.0F, 3.0F, 3.0Fwith3, 3, 3- same value, cleaner syntax.
650-650: LGTM: Consistent type usageGood balance between keeping necessary float precision (2.6F) while simplifying integer values (4 instead of 4.0F).
858-858: LGTM: Clean numeric literalsSimplified integer representation aligns with the PR's cleanup goals.
src/main/java/com/paneedah/mwc/items/guns/Glock19Factory.java (3)
245-245: Simplified float notation inwithScalemethod.Removed redundant
.0Fnotation from the scale parameters, simplifying them to integer values which are automatically converted to floats when needed.
498-498: Simplified float notation inwithScalemethod.Removed redundant
.0Fnotation from the first two parameters while keeping the format consistent with the rest of the codebase.
516-516: Simplified float notation inwithScalemethod.Removed redundant
.0Fnotation from the first two parameters, improving code readability while maintaining functionality.src/main/java/com/paneedah/mwc/items/guns/ChiappaRhinoFactory.java (1)
49-49: Simplified float notation inwithScreenShakingmethod.Changed
1.0fto1for the y-parameter, removing the unnecessary floating-point suffix while preserving the same numerical value. This change aligns with the PR objective of cleaning up redundant float declarations.src/main/java/com/paneedah/mwc/items/guns/turret/TurretGunFactory.java (3)
86-86: Style cleanup: Removed redundant float notation on whole numbers.The change from
.withScale(3.0F, 3.0F, 3.0F)to.withScale(3, 3, 3)aligns with the PR objective of removing unnecessary float declarations, making the code cleaner without affecting functionality.
95-95: Style cleanup: Removed redundant float notation on whole number parameter.The change from
.withScale(2.6F, 2.6F, 4.0F)to.withScale(2.6F, 2.6F, 4)maintains floating-point notation for non-whole numbers while removing it from the integer value, improving code readability.
128-128: Style cleanup: Removed redundant float notation on whole number parameter.The change from
.withScale(2.6F, 2.6F, 4.0F)to.withScale(2.6F, 2.6F, 4)is consistent with the style changes throughout the codebase, removing unnecessary float notation from integer values.src/main/java/com/paneedah/mwc/items/guns/Remington870Factory.java (1)
465-465: Style cleanup: Removed redundant float notation on whole number parameter.The change from
.glTranslatef(-0.18f, 0.5f, -1.0f)to.glTranslatef(-0.18f, 0.5f, -1)removes the unnecessary float notation from the integer z-coordinate value, making the code cleaner while maintaining the same functionality.src/main/java/com/paneedah/mwc/items/guns/ScarLFactory.java (3)
422-422: Code cleanup: Integer instead of float with zero decimalRemoved unnecessary float notation by using integer literals where the fractional part is zero. This is more concise.
431-431: Code cleanup: Simplified numeric literalChanged 4.0F to 4 to remove redundant float notation while preserving the same value.
658-658: Code cleanup: Integer instead of float with zero decimalSimplified 4.0F to 4 by removing unnecessary float notation for integers.
src/main/java/com/paneedah/mwc/items/guns/FNFALFactory.java (3)
369-369: Code cleanup: Integer literals instead of float literalsChanged 3.0F to 3 for cleaner code while maintaining the same functionality.
378-378: Code cleanup: Simplified numeric literalChanged 4.0F to 4 for the third parameter while keeping 2.8F for the first two parameters where the decimal is significant.
617-617: Code cleanup: Integer instead of float with zero decimalRemoved unnecessary float notation for the integer 4, making the code more concise.
src/main/java/com/paneedah/mwc/items/guns/SIGMCXFactory.java (5)
567-567: Code cleanup: Integer literals instead of float literalsSimplified the scale parameters by using integer literals instead of float literals with zero decimals.
576-576: Code cleanup: Simplified numeric literalChanged 4.0F to 4 in the scale parameter while preserving the decimal notation where needed.
679-679: Code cleanup: Integer instead of float zeroReplaced 0.0f with 0 for a cleaner representation of zero.
704-704: Code cleanup: Integer literal for zeroChanged -0.0f to -0 as they're functionally equivalent, and the integer representation is more concise.
785-785: Code cleanup: Simplified float representationRemoved unnecessary decimal point and F suffix for the integer 4 in the scale parameters.
src/main/java/com/paneedah/mwc/items/guns/G36CFactory.java (2)
329-329: Converting float literal to integer for whole number value.The change from
4.0Fto4in the third parameter of thewithScalemethod aligns with the PR's goal of removing unnecessary float declarations for whole numbers. This won't affect functionality as Java automatically performs a widening primitive conversion.
521-521: Consistent float-to-integer conversion pattern.Similar to the earlier change, this replaces the
4.0Fliteral with4while keeping the decimal values (2.6F) as floats. This is a consistent application of the cleanup pattern throughout the codebase.src/main/java/com/paneedah/mwc/items/guns/M1897Factory.java (2)
209-209: Simplified numeric representation in translation coordinates.Changed the third parameter in
glTranslateffrom-1.0fto-1, removing the unnecessary decimal and suffix for the whole number value. This simplification improves code clarity while maintaining identical functionality.
290-290: Consistent integer literal usage for whole number values.Same pattern of replacing
-1.0fwith-1in the third parameter ofglTranslatef. The change is consistent with the overall cleanup approach and follows the same pattern as other changes in the codebase.src/main/java/com/paneedah/mwc/items/guns/M17Factory.java (3)
157-157: Simplified scale parameters from float to integer literals.All three parameters in
withScalehave been changed from3.0Fto3, removing the unnecessary floating-point representation for whole numbers. This simplification improves code readability without changing functionality.
227-227: Standardized numeric literal representation.Changed the third parameter from
4.0Fto4while maintaining the decimal values (2.6F) as floats. This selective approach properly targets only whole numbers for cleanup while preserving necessary precision for decimal values.
245-245: Consistent cleanup of float notation.Same pattern as line 227, replacing
4.0Fwith4for the third scale parameter. This maintains consistency throughout the modifying handler implementations.src/main/java/com/paneedah/mwc/items/guns/ScarHFactory.java (2)
405-406: Clarify literal representation in first person positioning scale.
The change from a floating‑point literal (e.g. “3.0F”) to an integer literal “3” for a whole‐number scale value is appropriate. This simplifies the numeric representation without affecting functionality.
414-415: Update left-hand scale parameters for clarity.
The modification of the scale from “(2.6F, 2.6F, 4.0F)” to “(2.6F, 2.6F, 4)” intelligently removes an unnecessary float suffix from the whole‑number value while preserving the intended non‑integer values in the non‐whole components.src/main/java/com/paneedah/mwc/items/guns/M9A1Factory.java (2)
213-214: Standardize first person positioning scale literals.
Changing the scale literal from a float format (likely “3.0F”) to an integer “3” improves code clarity and consistency since the value represents a whole number. No downstream impact is expected.
221-223: Refine first person hand positioning left-hand scale.
The update—from using an unnecessary “4.0F” to the simpler “4” in the left hand’s scale call—aligns with the project’s objective to eliminate redundant float declarations for whole numbers. The preservation of non‐whole float values (e.g. “2.6F”) is correct.src/main/java/com/paneedah/mwc/items/guns/M16A1Factory.java (2)
412-416: Simplify first person positioning scale values.
Switching from “.withScale(3.0F, 3.0F, 3.0F)” to “.withScale(3, 3, 3)” removes needless float suffixes on whole numbers. This promotes clarity and adheres to the codebase’s guidelines without altering behavior.
424-427: Refine left-hand scale in first person hand positioning.
Reducing “4.0F” to “4” in the scale parameters (while keeping the non‑integer values intact, as with “2.6F”) removes unnecessary verbosity. This change meets the PR objective for standardizing numeric representation.src/main/java/com/paneedah/mwc/items/guns/DSR1Factory.java (5)
135-135: Clean numeric representation.Changed from floating point
-1.0Fto integer-1for the z-parameter in the translation, which aligns with the PR goal of eliminating unnecessary float representations for whole numbers.
144-144: Clean numeric representation.Changed from floating point
-1.0Fto integer-1for the z-parameter in the translation, maintaining consistency with the previous change.
211-211: Clean numeric representation.Changed from floating point
-1.0Fto integer-1for the z-parameter in the translation, keeping consistent with the pattern of simplifying float literals.
220-220: Clean numeric representation.Changed from floating point
-1.0Fto integer-1for the z-parameter in the translation, continuing the consistent pattern of simplification.
1204-1204: Clean numeric representation.Changed from floating point
0.0fto integer0for the z-parameter in the translation, completing the standardization of numeric literals in this file.src/main/java/com/paneedah/mwc/items/guns/DesertEagleFactory.java (3)
142-142: Clean numeric representation in scale parameters.Changed from floating point
3.0F, 3.0F, 3.0Fto integer3, 3, 3in the scale parameters, which aligns with the PR objective of removing unnecessary float declarations for whole numbers.
216-216: Clean numeric representation for scale z-parameter.Changed from floating point
4.0Fto integer4for the z-parameter of the scale, while correctly maintaining the floating point format for the non-whole values (2.6F).
234-234: Clean numeric representation for scale z-parameter.Changed from floating point
4.0Fto integer4for the z-parameter of the scale, maintaining consistency with the previous similar change.src/main/java/com/paneedah/mwc/items/guns/M110Factory.java (2)
392-392: Standardized scale parameters using integer literals.The change from
.withScale(3.0F, 3.0F, 3.0F)to.withScale(3, 3, 3)simplifies the code by removing redundant float declarations for whole numbers, improving readability.
401-401: Simplified floating-point representation in scale parameters.The change from
.withScale(2.6F, 2.6F, 4.0F)to.withScale(2.6F, 2.6F, 4)removes the unnecessary.0Fsuffix from the whole number, making the code more consistent and cleaner.src/main/java/com/paneedah/mwc/items/guns/MP5A5Factory.java (5)
432-432: Standardized scale parameters using integer literals.Changed
.withScale(3.0F, 3.0F, 3.0F)to.withScale(3, 3, 3), removing redundant float notations for whole numbers as per the cleanup initiative.
441-441: Simplified floating-point representation in scale parameters.Modified
.withScale(2.6F, 2.6F, 4.0F)to.withScale(2.6F, 2.6F, 4), removing the unnecessary.0Fsuffix from the whole number.
449-449: Standardized scale parameters using integer literals.Changed
.withScale(3.0F, 3.0F, 3.0F)to.withScale(3, 3, 3), following the consistent pattern of simplifying whole number float declarations throughout the codebase.
571-571: Simplified negative zero representation.Changed
GL11.glTranslatef(0.18f, -0.21f, -0.0f)toGL11.glTranslatef(0.18f, -0.21f, -0), removing redundant floating-point notation for zero value.
699-699: Simplified floating-point representation in scale parameters.Modified
.withScale(2.6F, 2.6F, 4.0F)to.withScale(2.6F, 2.6F, 4), removing the unnecessary.0Fsuffix from the whole number, which is consistent with the cleanup initiative.src/main/java/com/paneedah/mwc/items/guns/AACHoneyBadgerFactory.java (3)
597-597: Standardized scale parameters using integer literals.Changed
.withScale(3.0F, 3.0F, 3.0F)to.withScale(3, 3, 3), following the consistent pattern of using integer literals for whole numbers instead of floats with.0Fsuffix.
606-606: Simplified floating-point representation in scale parameters.Modified
.withScale(2.6F, 2.6F, 4.0F)to.withScale(2.6F, 2.6F, 4), removing the unnecessary.0Fsuffix from the whole number for better code clarity.
816-816: Simplified floating-point representation in scale parameters.Changed
.withScale(2.6F, 2.6F, 4.0F)to.withScale(2.6F, 2.6F, 4), following the consistent cleanup initiative to remove redundant float notations for whole numbers.src/main/java/com/paneedah/mwc/items/guns/KrissVectorFactory.java (3)
531-531: Clean conversion from float to integer literalGood change! Converting
3.0F, 3.0F, 3.0Fto3, 3, 3removes unnecessary decimal zeroes and type suffixes while preserving the same values, making the code more concise.
540-540: Appropriate numeric format standardizationGood change! Keeping
2.6Fas a float (since it has a meaningful decimal part) while converting4.0Fto4aligns with the PR objective of removing only unnecessary float declarations.
879-879: Consistent numerical format applicationThe change from
2.6F, 2.6F, 4.0Fto2.6F, 2.6F, 4is consistent with the other changes in this file, keeping necessary float declarations while removing the unnecessary ones.src/main/java/com/paneedah/mwc/items/guns/AK74Factory.java (3)
499-499: Good cleanup of unnecessary float notationConsistent with the PR's goal, this change appropriately removes the redundant
.0Fnotation from integer values, making the code cleaner while maintaining the same functionality.
508-508: Appropriate format selection for numeric literalsGood change. You've correctly maintained the float notation for the values that need it (
2.8F) while removing unnecessary float notation from the integer value (4instead of4.0F).
778-778: Consistent numeric standardizationThis change from
2.6F, 2.6F, 4.0Fto2.6F, 2.6F, 4follows the same pattern as the other changes in the codebase, ensuring consistency while removing redundant type information.src/main/java/com/paneedah/mwc/items/guns/M38Factory.java (3)
525-525: Clean integer representationGood change converting
3.0F, 3.0F, 3.0Fto3, 3, 3, which removes the redundant decimal zero and type suffix while maintaining the same values.
534-534: Appropriate float-to-integer conversionGood job keeping
2.6Fas floats (since they have decimal components) while removing the unnecessary float notation from4.0F→4, making the code cleaner while preserving semantics.
766-766: Consistent numeric standardizationThis change maintains the consistent code style pattern applied throughout the PR, keeping necessary float declarations while eliminating redundant ones.
src/main/java/com/paneedah/mwc/items/guns/ACRFactory.java (2)
651-651: Code cleanup: simplified float notation for whole numbers.Removed redundant
.0Ffloat notation on whole numbers to improve code clarity, in line with the documented best practices.
660-660: Code cleanup: simplified float notation for whole numbers.Removed redundant
.0Ffloat notation from the last parameter while preserving the float notation for the non-whole numbers.src/main/java/com/paneedah/mwc/items/guns/Glock18CFactory.java (3)
205-205: Code cleanup: simplified float notation for whole numbers.Removed unnecessary
.0Ffloat notation on whole numbers to improve code readability.
375-375: Code cleanup: simplified float notation for whole numbers.Removed redundant
.0Ffloat notation from the last parameter while maintaining float notation for the decimal numbers.
393-393: Code cleanup: simplified float notation for whole numbers.Removed unnecessary
.0Ffloat notation from the last parameter in the modifying alt handler.src/main/java/com/paneedah/mwc/items/guns/HK417Factory.java (3)
611-611: Code cleanup: simplified float notation for whole numbers.Removed unnecessary
.0Ffloat notation on whole numbers to improve code readability and consistency.
620-620: Code cleanup: simplified float notation for whole numbers.Removed redundant
.0Ffloat notation from the last parameter while preserving float notation for the decimal values.
837-837: Code cleanup: simplified float notation for whole numbers.Removed unnecessary
.0Ffloat notation from the last parameter in this position modifying handler, consistent with other similar changes.src/main/java/com/paneedah/mwc/models/ACRAction2.java (3)
24-25: Code cleanup: simplified float notation for whole numbers.Removed redundant
.0Ffloat notation from the expansion parameter in ModelBox constructor calls. This improves code readability without changing functionality.
30-31: Code cleanup: simplified float notation for whole numbers.Removed unnecessary
.0Ffloat notation for zero values in the rotation angle parameters and for whole number values in the ModelBox dimensions.
36-37: Code cleanup: simplified float notation for whole numbers.Removed redundant
.0Ffloat notation for zero values in the rotation angle parameters and for whole numbers in the ModelBox dimensions.src/main/java/com/paneedah/mwc/items/guns/AR10SuperSASSFactory.java (2)
634-634: Clean transformation from floating-point to integer literalsThe change from
.withScale(3.0F, 3.0F, 3.0F)to.withScale(3, 3, 3)simplifies the code by removing unnecessary decimal zeros, making it more readable while maintaining the same functionality.
643-643: Good simplification of numeric literalReplacing the floating-point literal
4.0Fwith integer4in the third parameter reduces unnecessary verbosity while maintaining the same behavior.src/main/java/com/paneedah/mwc/items/guns/ScorpionEVO3A1Factory.java (3)
375-375: Clean code simplificationConverting
.withScale(3.0F, 3.0F, 3.0F)to.withScale(3, 3, 3)is a good simplification that makes the code more readable while maintaining identical functionality.
384-384: Consistent simplification patternGood cleanup of the third parameter from
4.0Fto4, which follows the same simplification pattern being applied throughout the codebase.
581-581: Appropriate simplificationReplacing the floating-point literal
4.0Fwith integer4enhances readability while preserving the same functionality.src/main/java/com/paneedah/mwc/items/guns/P226Factory.java (3)
174-174: Cleaner numeric representationGood transformation from
.withScale(3.0F, 3.0F, 3.0F)to.withScale(3, 3, 3), removing unnecessary floating-point notation while maintaining the same behavior.
337-337: Simplified numeric formatThe change from
.withScale(2.6F, 2.6F, 4.0F)to.withScale(2.6F, 2.6F, 4)is appropriate, removing unnecessary decimal zeros from the integer value.
355-355: Consistent cleanup appliedGood simplification of the third parameter from
4.0Fto4, aligning with the cleanup pattern applied throughout the codebase.src/main/java/com/paneedah/mwc/items/guns/VP70Factory.java (3)
125-125: Cleaner code representationGood transformation from
.withScale(3.0F, 3.0F, 3.0F)to.withScale(3, 3, 3), which helps reduce verbosity while maintaining identical functionality.
286-286: Appropriately simplified numeric literalConverting the third parameter from
4.0Fto4is a sensible cleanup that maintains the same behavior while improving readability.
304-304: Consistent cleanup approachGood change from
.withScale(2.6F, 2.6F, 4.0F)to.withScale(2.6F, 2.6F, 4), following the same pattern of removing unnecessary floating-point notation for whole numbers.src/main/java/com/paneedah/mwc/items/guns/F2000Factory.java (2)
388-388: Clean representation using integers instead of floating-point literals.Converting
3.0Fto3reduces verbosity while maintaining the same functionality. Integer literals are implicitly converted to float when needed.
397-397: Consistent cleanup of float notation.Good change replacing
4.0Fwith4while keeping the fractional values as floats where needed.src/main/java/com/paneedah/mwc/items/guns/MakarovPMFactory.java (3)
155-155: Simplified scale parameter representation.Good change replacing floating-point literals with integer literals for whole numbers.
315-315: Consistent cleanup of unnecessary float notation.Converting
4.0Fto4matches the PR objective of removing redundant float declarations.
333-333: Simplified float notation for scale parameter.Good consistency in changing from
4.0Fto4while keeping fractional values as floats.src/main/java/com/paneedah/mwc/items/guns/G11Factory.java (3)
252-252: Cleaner scale parameter syntax.Good simplification of whole number float literals to integers.
261-261: Simplified scale parameter notation.Good change removing unnecessary decimal point and 'F' suffix for the whole number.
400-400: Consistent cleanup of float notation.Good alignment with the code cleanup objective by replacing
4.0Fwith4.src/main/java/com/paneedah/mwc/items/guns/AK12Factory.java (3)
349-349: Clean integer representation for scale parameters.Good simplification by using integers instead of floats for whole numbers.
358-358: Simplified float notation for whole number parameter.Good change removing redundant decimal point and 'F' suffix from the integer value.
608-608: Consistent cleanup of float notation.Good standardization of code style by changing
4.0Fto4.src/main/java/com/paneedah/mwc/items/guns/AK47Factory.java (3)
510-510: Clean removal of unnecessary float notation.The change from
3.0Fto3for whole number values simplifies the code without affecting functionality, as integers are automatically promoted to floats when required.
519-519: Good simplification of integer value representation.Maintains the float notation for the fractional values (2.8F) while properly simplifying the whole number (4.0F to 4), consistent with the PR's goal of removing unnecessary float declarations.
779-779: Consistent simplification of whole number value.The change from
4.0Fto4follows the same pattern as other changes, maintaining fractional values as floats (2.6F) while simplifying whole numbers to integers.src/main/java/com/paneedah/mwc/items/guns/M16A4Factory.java (3)
727-727: Clean removal of unnecessary float notation.The change from
3.0Fto3for whole number values simplifies the code without affecting functionality, as integers are automatically promoted to floats when required.
736-736: Good simplification of integer value representation.Maintains the float notation for the fractional values (2.6F) while properly simplifying the whole number (4.0F to 4), consistent with the PR's goal of removing unnecessary float declarations.
967-967: Consistent simplification of whole number value.The change from
4.0Fto4follows the same pattern as other changes, maintaining fractional values as floats (2.6F) while simplifying whole numbers to integers.src/main/java/com/paneedah/mwc/items/guns/NinthSinFactory.java (1)
23-23: Clean and consistent integer representation.Changed floating-point literal
0.0fto integer0for the recoil parameter, which is consistent with the PR's goal of removing unnecessary float declarations.src/main/java/com/paneedah/mwc/models/ACRFixedStock.java (27)
48-56: Clean and consistent integer representation in ModelBox parameters.Changed the last parameter in ModelBox constructor calls from
0.0Fto0, maintaining functionality while simplifying the numeric representation.
62-64: Simplified rotation angle parameters.Changed explicit float values
0.0Fto integer0in setRotationAngle method call, which is automatically converted to float when needed.
69-73: Consistent integer usage in cubeList entries.Changed trailing zeros in float literals to integer values in ModelBox constructor calls, maintaining consistent numeric representation across the codebase.
78-78: Clean model parameter representation.Changed ModelBox parameter from float with trailing zero to integer, simplifying the code while maintaining identical functionality.
84-84: Integer simplification for zero decimal values.Simplified
0.0Fto0in ModelBox parameter for cleaner code representation.
90-90: Consistent numeric representation.Changed ModelBox parameter from floating-point with trailing zero to integer, aligned with project-wide standardization.
96-98: Standardized numeric representation in model definition.Changed multiple ModelBox parameters from float to integer for values with zero decimal places, improving code clarity without changing functionality.
104-104: Clean numeric value representation.Changed
0.0Fto0in ModelBox constructor parameter, maintaining consistency with other changes in the codebase.
109-110: Simplified angle parameters and model definition.Changed rotation angle parameters from explicit floats to integers, and similarly updated ModelBox constructor parameters.
115-116: Consistent angle and model parameter representation.Simplified both setRotationAngle parameters and ModelBox constructor parameter from
0.0Fto0for cleaner code.
121-122: Standardized numeric representation in rotation and model parameters.Consistently updated both rotation angle parameters and ModelBox constructor parameter to use integers instead of floats with zero decimal places.
127-128: Clean angle and model parameter representation.Updated setRotationAngle parameters and ModelBox constructor parameter to use integer
0instead of float0.0F.
133-134: Simplified numeric parameters.Changed rotation angle and ModelBox parameters from floating-point with trailing zeros to integers for cleaner code.
139-141: Standardized numeric representation throughout model definition.Updated rotation angle parameters and multiple ModelBox constructor parameters to use integers instead of floats with zero decimal places.
147-148: Consistent integer usage for zero decimal values.Changed ModelBox constructor parameters from
0.0Fto0, improving code consistency and readability.
154-155: Clean model parameter representation.Standardized ModelBox constructor parameters to use integer
0instead of float0.0F.
160-161: Simplified angle and model parameters.Changed both rotation angle and ModelBox parameters from explicit floats to integers where decimal part is zero.
166-169: Consistent integer representation in model definition.Updated setRotationAngle parameters and multiple ModelBox constructor parameters to use integers instead of floats with zero decimal places.
174-177: Standardized numeric parameters throughout model definition.Changed setRotationAngle parameters and multiple ModelBox constructor parameters to use integers for zero decimal values.
182-183: Clean angle and model parameter representation.Simplified setRotationAngle parameters and ModelBox constructor parameter by using integer
0instead of float0.0F.
188-189: Consistent numeric parameter representation.Updated both rotation angle and ModelBox parameters from explicit floats to integers where the decimal part is zero.
195-196: Clean model parameter representation.Changed ModelBox constructor parameters from float with trailing zero to integer for cleaner code.
202-203: Standardized model parameter representation.Updated ModelBox constructor parameters to use integer
0instead of float0.0Ffor consistent style.
208-209: Simplified angle and model parameters.Changed both rotation angle parameters and ModelBox constructor parameter to use integers instead of floats with zero decimal places.
214-215: Clean angle and model parameter representation.Standardized setRotationAngle parameters and ModelBox constructor parameter to use integer
0instead of float0.0F.
220-221: Consistent numeric representation in model definition.Updated rotation angle parameters and ModelBox constructor parameter from floating-point with trailing zeros to integers.
226-227: Standardized numeric parameters in model definition.Changed setRotationAngle parameters and ModelBox constructor parameter to use integers for zero decimal values, maintaining consistent style across the codebase.
src/main/java/com/paneedah/mwc/items/guns/UMP45Factory.java (4)
324-324: Clean numeric representation change.The code now uses integer literals where appropriate instead of floating-point literals with
.0Fsuffix. This makes the code cleaner and more readable.
333-333: Appropriate mixed numeric format.Good use of mixed formatting - keeping decimal places where needed (2.6F) while removing unnecessary
.0Fsuffix from the integer value (4).
341-341: Clean numeric representation change.The code now uses integer literals where appropriate instead of floating-point literals with
.0Fsuffix, consistent with the PR objectives.
539-539: Appropriate mixed numeric format.Good use of mixed formatting - keeping decimal places where needed (2.6F) while removing unnecessary
.0Fsuffix from the integer value (4).src/main/java/com/paneedah/mwc/items/guns/M40A6Factory.java (3)
300-300: Clean numeric representation change.The code now uses integer literals where appropriate instead of floating-point literals with
.0Fsuffix. This makes the code cleaner and more readable.
309-309: Appropriate mixed numeric format.Good use of mixed formatting - keeping decimal places where needed (2.6F) while removing unnecessary
.0Fsuffix from the integer value (4).
452-452: Appropriate mixed numeric format.Good use of mixed formatting - keeping decimal places where needed (2.6F) while removing unnecessary
.0Fsuffix from the integer value (4).src/main/java/com/paneedah/mwc/models/ACRSBRHandguard.java (9)
30-31: Simplified zero parameters in ModelBox constructor.Removed unnecessary
.0Fsuffix from the zero parameters, making the code cleaner and more readable.
36-37: Simplified rotation angle parameters.Removed unnecessary
.0Fsuffix from zero angle parameters while keeping the precision on the non-zero angle (-2.5133F).
42-43: Simplified rotation angle parameters.Removed unnecessary
.0Fsuffix from zero angle parameters while keeping the precision on the non-zero angles (0.3316F, -2.5133F).
48-49: Simplified rotation angle parameters.Removed unnecessary
.0Fsuffix from zero angle parameters while keeping the precision on the non-zero angle (2.5133F).
54-55: Simplified rotation angle parameters.Removed unnecessary
.0Fsuffix from zero angle parameters while keeping the precision on the non-zero angles (0.3316F, 2.5133F).
60-85: Simplified ModelBox constructors.Removed unnecessary
.0Fsuffix from the zero parameters across multiple ModelBox constructor calls, making the code cleaner and more consistent.
90-91: Simplified rotation angle parameters.Removed unnecessary
.0Fsuffix from zero angle parameters while keeping the precision on the non-zero angle (-0.7679F).
95-98: Simplified rotation parameters.Line 95 modifies a position parameter, and lines 97-98 simplify rotation parameters by removing unnecessary
.0Fsuffix from zero angles.
100-104: Simplified rotation parameters.Line 101 modifies a position parameter, and lines 103-104 simplify rotation parameters by removing unnecessary
.0Fsuffix from zero angles.src/main/java/com/paneedah/mwc/items/guns/SVDDragunovFactory.java (4)
196-196: Simplified GL transformation parameter.Removed unnecessary
.0Fsuffix from the integer value in the Z-coordinate parameter, making the code cleaner.
344-344: Clean numeric representation change.The code now uses integer literals where appropriate instead of floating-point literals with
.0Fsuffix. This makes the code cleaner and more readable.
353-353: Appropriate mixed numeric format.Good use of mixed formatting - keeping decimal places where needed (2.8F) while removing unnecessary
.0Fsuffix from the integer value (4).
620-620: Appropriate mixed numeric format.Good use of mixed formatting - keeping decimal places where needed (2.6F) while removing unnecessary
.0Fsuffix from the integer value (4).src/main/java/com/paneedah/mwc/models/AACHoneyBadgerStock.java (2)
37-60: Standardized Numeric Representations in Stock Initialization
In these lines the code now calls
stock.setRotationPoint(0, 24, 0)
and uses manyModelBoxconstructor calls where the final “offset” parameter is now written as an integer (e.g. using0instead of0.0F). This cleanup improves clarity and removes an unnecessary use of floats for whole numbers without affecting functionality.
61-175: Consistent Numeric Cleanup in Child Renderers and Bone Definitions
The child model parts (such as those forgun775_r1,gun774_r1, and subsequent bone segments) now use integer literals for whole‐number values in methods likesetRotationPointandsetRotationAnglewhen appropriate while retaining float precision for non‑whole numbers. This consistent update across the entire constructor ensures clarity and conforms to the project guidelines.src/main/java/com/paneedah/mwc/items/guns/KS23Factory.java (1)
225-231: Numeric Literal Cleanup in GL11 Transformations
Within the eject spent round Transition blocks, theGL11.glTranslatefcalls now pass whole‐number values as integers (for example, replacing a previous-1.0Fwith-1). This change is applied in both the standard and aimed eject transitions and aligns perfectly with the goal of removing redundant float declarations.Also applies to: 259-266
src/main/java/com/paneedah/mwc/models/ACRPRSStock.java (1)
43-199: Uniform Numeric Literal Standardization
Across this model class theModelBoxconstructor calls and the transformation methods (including calls tosetRotationAngle) have been updated by replacing floating‑point literals that represent whole numbers with integers. These changes make the code easier to read and are consistent with the project’s cleanup guidelines while leaving the geometric definitions unchanged.src/main/java/com/paneedah/mwc/models/AACHoneyBadgerSilencer.java (1)
25-33: Consistent Redundant Float Removal in Silencer Model
The silencer model now calls
silencer.setRotationPoint(0, 24, 0)
and in allModelBoxadditions the last parameter is now given as an integer (e.g.0instead of0.0F). In addition, transformation calls such assetRotationAnglesimilarly use integer literals where possible. This uniform update improves consistency with the cleanup objective.Also applies to: 36-62
src/main/java/com/paneedah/mwc/items/guns/APSFactory.java (1)
146-147: Refined Scaling Literal Representation
In APSFactory the calls to thewithScalemethod have been refined so that whole number scale factors are expressed as integers rather than floats (for example, using3instead of3.0Fand4instead of4.0F). Note that non‑whole numbers (such as2.6F) are preserved in order not to lose the intended visual precision. This update is a clear win for consistency and readability.Also applies to: 296-300
src/main/java/com/paneedah/mwc/models/AACKnightsArmamentReceiver.java (1)
55-55: Simplification of floating-point literals looks good.The changes simplify whole number floating-point literals (like 0.0F, -9.0F) to integer literals (0, -9) consistently throughout the model definition. This improves code readability while maintaining identical functionality since Java implicitly converts integers to floats when needed.
Also applies to: 59-61, 62-63, 67-69, 74-75, 78-84, 86-89, 94-95, 100-101, 104-107, 112-113, 117-119, 122-125, 129-131, 136-137, 142-145, 148-149, 154-156, 162-165, 168-170, 178-181, 184-186, 194-196, 204-206, 211-212, 215-218, 223-224, 237-243, 246-249, 252-256
src/main/java/com/paneedah/mwc/items/guns/KBP9A91Factory.java (3)
177-177: Integer literals for whole number scales - good change.Converting from
withScale(3.0F, 3.0F, 3.0F)towithScale(3, 3, 3)simplifies the code and aligns with the PR objective of removing unnecessary float declarations.
186-186: Consistent style improvement for scale parameters.Changed from
withScale(2.8F, 2.8F, 4.0F)towithScale(2.8F, 2.8F, 4). This maintains the necessary float precision where needed (2.8F) while simplifying the whole number (4).
317-317: Simplified GL translation parameter.Changed from
GL11.glTranslatef(-0.015F, 0.2f, 0.0f)toGL11.glTranslatef(-0.015F, 0.2f, 0). Appropriate simplification of the z-parameter that removes the unnecessary float suffix.src/main/java/com/paneedah/mwc/items/guns/SCCYCPX2Factory.java (2)
164-164: Integer literals for scale parameters - good refactoring.Changed from
withScale(3.0F, 3.0F, 3.0F)towithScale(3, 3, 3)which simplifies the code while maintaining identical functionality.
330-330: Consistent simplification of scale parameters.Both instances changed from
withScale(2.6F, 2.6F, 4.0F)towithScale(2.6F, 2.6F, 4), keeping fractional values as floats while converting whole numbers to integers. This maintains a consistent approach throughout the codebase.Also applies to: 348-348
src/main/java/com/paneedah/mwc/items/guns/Mk14EBRFactory.java (2)
470-470: Simplified scale parameters with integers.Changed from
withScale(3.0F, 3.0F, 3.0F)towithScale(3, 3, 3)which removes unnecessary float declarations.
479-479: Consistent cleanup of whole number floats.Both instances follow the same pattern of changing
withScale(2.8F, 2.8F, 4.0F)towithScale(2.8F, 2.8F, 4)andwithScale(2.6F, 2.6F, 4.0F)towithScale(2.6F, 2.6F, 4). This maintains a consistent style while preserving necessary decimal precision.Also applies to: 730-730
src/main/java/com/paneedah/mwc/items/guns/SSG08Factory.java (1)
277-277: Cleaner numeric literals improve readabilityThe simplification of float literals where the decimal part is zero helps make the code cleaner and more concise while maintaining the same functionality. These types of cleanups improve code readability and follow the PR's goal of removing unnecessary
.0fdeclarations.Also applies to: 441-447, 500-506, 788-794
src/main/java/com/paneedah/mwc/items/guns/TaurusRagingHunterFactory.java (3)
136-136: Improved numeric literal readabilitySimplifying float literals from
3.0Fto3makes the code cleaner while maintaining the same functionality. Java will automatically promote the integer to a float when passing to methods that expect float parameters.
165-165: Cleaner numeric representationReplacing
-2.0fwith-2reduces visual noise in the code without changing behavior. This is a good cleanup.
205-205: Consistent literal simplificationGood cleanup by simplifying
4.0Fto4in the scale parameters, maintaining the same functionality while improving readability.Also applies to: 223-223
src/main/java/com/paneedah/mwc/items/guns/AK12_kalFactory.java (1)
400-410: Consistent Use of Integer Literals for Scale ParametersThe conversion of scale values from floating‑point literals (e.g., 3.0F, 4.0F) to integer literals (3, 4) in the various withScale calls conforms to the PR objective. This change removes unnecessary float decorations for whole numbers and improves code clarity without any loss of precision.
src/main/java/com/paneedah/mwc/models/ACRHandGuard.java (2)
31-44: Standardizing ModelBox Constructor LiteralsAll ModelBox constructor calls that specify a depth or extra scale value now use the integer literal 0 instead of 0.0F. Since the value is exactly zero, the conversion to an integer literal is safe and enhances readability.
46-54: Consistent Transformation Parameter LiteralsThe helper method calls such as setRotationAngle for child renderers (e.g. on handguard32_r1) now use 0 instead of 0.0F for the y‑ and z‑rotation arguments when the value is precisely zero. This change standardizes these parameters with the rest of the code.
src/main/java/com/paneedah/mwc/items/guns/AK15Factory.java (2)
423-424: Simplified Scale Literals in First‑Person PositioningThe first‑person positioning transformation now uses
.withScale(3, 3, 3)instead of a float literal variant (e.g. 3.0F). Removing the trailing “.0F” for whole numbers improves consistency and reduces visual clutter.
432-433: Refined Scale Parameter for Hand PositioningIn the left hand transformation the z‑axis scale is now specified as 4 instead of 4.0F while the other values remain as floats (since 2.8 isn’t a whole number). This selective standardization maintains necessary precision while cleaning up redundant formatting.
src/main/java/com/paneedah/mwc/items/guns/VSSVintorezFactory.java (4)
235-245: Optimized GL11 Translation LiteralsSeveral GL11.glTranslatef calls in the attachment configuration (for example, for the Reflex attachment) now use integer literals (e.g. –1 instead of –1.0F) for parameters that are whole numbers. This adjustment streamlines the numeric representation without affecting the rendering outcomes.
253-268: Consistent Application in Attachment ConfigurationsChanges in attachments such as Holographic and HolographicAlt now show GL11.glTranslatef calls that have been updated to use integer values (e.g. –1 instead of –1.0F) where no fractional part is needed. The removal of redundant “F” suffixes here enhances code uniformity.
368-369: Simplified First‑Person Positioning ScaleThe first‑person positioning transformation now uses a simplified call—using
.withScale(3, 3, 3)—instead of the extra “.0F” notation. This contributes to an overall cleaner and more consistent transformation configuration.
589-597: Standardized Translation in Zooming ConfigurationWithin the custom zooming configuration, changes such as replacing “0F” or “0.0F” with “0” ensure that translation values for whole numbers are written in their simplest form. This small but consistent change furthers code clarity while retaining the intended behavior.
src/main/java/com/paneedah/mwc/models/ACRLongRangeStock.java (2)
42-68: Consistent simplification of float literals.The change from
0.0Fto0simplifies the code while maintaining the same functionality since Java implicitly converts integer literals to floats when needed. This change aligns with the PR objective of removing unnecessary float declarations.
76-76: Clean up of rotation parameters.The simplification of
0.0Fto0in the setRotationAngle method calls maintains functionality while reducing unnecessary float notation. This is consistent with the PR's cleanup goals.Also applies to: 82-82, 88-88, 106-106, 112-112, 118-118, 124-124, 130-130, 153-153, 162-162, 168-168, 175-175, 181-181, 187-187, 193-193, 199-199
src/main/java/com/paneedah/mwc/items/guns/NGSWRFactory.java (4)
432-432: Simplified scale parameters.Replaced floating-point literals with equivalent integer literals for a cleaner representation. This maintains the same functionality while improving code readability.
441-441: Simplified scale parameters while preserving precision where needed.Keeping the floating-point representation for the first two parameters while simplifying the third parameter to an integer value maintains precision where required while removing unnecessary decimal notation.
539-539: Simplified translation parameter.Removed unnecessary floating-point notation for the middle parameter while preserving the float notation for parameters that require it. This is a consistent approach across the codebase.
564-564: Simplified translation parameter.Removing the decimal point from the middle parameter while maintaining it for other parameters where appropriate follows the PR's objective of removing unnecessary float declarations.
src/main/java/com/paneedah/mwc/items/guns/SIG556Factory.java (4)
457-457: Simplified translation parameter.Changed from
-0.0Fto-0for the y-translation parameter. Both represent the same value, but the simplified version aligns with the PR objective of cleaning up excessive float declarations.
511-511: Simplified scale parameters.Replaced floating-point literals with equivalent integer literals for a cleaner representation without changing functionality.
520-520: Consistent simplification of scale parameters.Maintained floating-point notation where precision is needed (first two parameters) while simplifying the integer parameter. This approach is consistent with changes throughout the codebase.
725-725: Consistent simplification pattern applied to hand positioning.Applied the same simplification pattern to hand positioning transform, preserving numeric values while removing unnecessary float notation.
src/main/java/com/paneedah/mwc/items/guns/ZbroyarZ10Factory.java (2)
407-411: Standardizing Scale Values in First-Person Positioning:
The change from using floating‑point literals (e.g. “3.0F”) to integer literals (3) in the call.withScale(3, 3, 3)improves readability when the scale value is a whole number. Since Java supports implicit conversion from int to float, this change is safe as long as the underlying method accepts a float.
416-422: Consistent Numeric Representation in Hand Positioning:
In the first‑person hand positioning transformation, the scale value for the z‑axis was changed from “4.0F” to “4” while retaining non‑whole numbers (e.g. “2.6F”) in the other parameters:.withScale(2.6F, 2.6F, 4)This is fully in line with the cleanup goals.
src/main/java/com/paneedah/mwc/items/guns/Spas12Factory.java (1)
337-343: Optimizing Float Declarations in Transition Translations:
In several reload transition blocks the call toGL11.glTranslatef(0, -0.03F, -0.075F);(and similar calls) now uses the integer literal 0 in place of “0.0F” for whole‑number offsets. This cleanup increases code clarity without impacting functionality, thanks to Java’s implicit conversion from int to float.
src/main/java/com/paneedah/mwc/models/AACHoneyBadgerHandguard.java (3)
24-26: Refinement of Rotation and Translation Parameters:
The callhandguard.setRotationPoint(0, 24, 0);now uses integer literals for whole‑number values. This improves readability and aligns with the goal of avoiding redundant float declarations while preserving precision where required.
40-49: Adjustments in Sub-Component Transformations:
The changes in the initialization of “bone5_r1”—including using integer 0 for components when no fractional precision is needed—and the subsequent ModelBox additions clearly separate whole-number values from truly fractional values (like –38.5F). This level of clarity benefits maintainability.
52-58: Consistent Numeric Literals in Child Components:
Similar adjustments in “bone6_r1” and “bone4_r1” (using integer 0 instead of 0.0F where applicable) show a consistent cleanup effort. Please verify that these minor changes do not impact the visual output—but overall they serve to make the code more concise.src/main/java/com/paneedah/mwc/items/guns/ARX160Factory.java (2)
369-373: Streamlining Scale Transformations:
The updated first‑person positioning now calls.withScale(3, 3, 3)instead of using “3.0F” literals. This change is consistent with the overall cleanup objective of eliminating redundant float notation for whole numbers while keeping the functionality intact via implicit conversion.
536-538: Uniform Numeric Representation in Hand Positioning:
In the hand positioning block, the scale is set with.withScale(2.6F, 2.6F, 4)where the third parameter (a whole number) is now represented as an integer (4) rather than “4.0F”. This maintains necessary precision for fractional values (2.6F) yet simplifies whole-number arguments, leading to improved consistency across the codebase.
src/main/java/com/paneedah/mwc/items/guns/M4A1Factory.java (3)
103-103: Consistent simplification of float literal.The change from
0.0fto0eliminates unnecessary decimal point and suffix for whole number values, improving code readability while maintaining identical behavior.
944-944: Good cleanup of redundant float literals.Converting
3.0F, 3.0F, 3.0Fto3, 3, 3removes unnecessary decimal points and type suffixes for whole number values, making the code cleaner while preserving identical behavior.
953-953: Improved numeric literal representation.Simplified
4.0Fto4while keeping2.6Fvalues that need decimal precision. This change maintains consistency with the PR goal of removing unnecessary float declarations for whole numbers.src/main/java/com/paneedah/mwc/items/guns/Type20Factory.java (5)
349-349: Simplified integer representations.Replacing
3.0F, 3.0F, 3.0Fwith3, 3, 3removes redundant decimal points and type suffixes, improving code readability while maintaining identical functionality.
358-358: Consistent cleanup of float literals.Changed
4.0Fto4while preserving the necessary floating point notation for the2.6Fvalues that require decimal precision.
452-452: Simplified numeric representation.Removed unnecessary decimal point and suffix from
0.0f, replacing it with a cleaner0that has identical behavior in this context.
482-482: Improved number formatting consistency.Changed
0.0fto0while keeping the floating-point notation for values that require decimal precision. This creates cleaner, more readable code.
579-579: Simplified whole number representation.The change from
4.0Fto4follows the PR goal of eliminating redundant float declarations while preserving the necessary precision for non-integer values.src/main/java/com/paneedah/mwc/models/ACRPDWStock.java (2)
36-49: Simplified ModelBox constructor parameters.Consistently changed the last parameter in all ModelBox constructors from
0.0Fto0, removing redundant float declarations for whole number values while maintaining identical behavior.
54-54: Standardized rotation angle parameters.Changed zero angle parameters from
0.0Fto0in all setRotationAngle method calls, creating more consistent and readable code while preserving the same functionality.Also applies to: 60-60, 66-66, 72-72, 81-81, 87-87, 93-93, 99-99, 106-106, 113-113, 120-120, 127-127
src/main/java/com/paneedah/mwc/items/guns/FamasF1Factory.java (3)
316-316: Clean Up Scale Literals in First-Person Positioning
The call to.withScale(3, 3, 3)now uses integer literals instead of3.0Ffor a whole number value. This aligns with the PR objective by removing unnecessary float markers.
325-325: Refine Mixed-Type Scale Parameters
Here the third parameter in.withScale(2.6F, 2.6F, 4)has been changed from4.0Fto4while preserving the decimal values for the non‐integral dimensions. This is appropriate since only the whole‑number dimensions needed the cleanup.
581-581: Standardize Scale in Hand Positioning Modification
The transformation call now uses.withScale(2.6F, 2.6F, 4)(with the third parameter as an integer) in the “modifying” block. This is consistent with the overall intent to remove redundant float declarations for whole numbers.src/main/java/com/paneedah/mwc/items/guns/MPXFactory.java (1)
304-306: Consistent Translation Literals for Attachments
In thewithCompatibleAttachment(Attachments.AimpointCompM2, …)block the translation call now readsGL11.glTranslatef(-0.12F, -1, -1F);—using
-1instead of-1.0Ffor whole-number values. This helps standardize numeric representations throughout the code and is acceptable given Java’s automatic conversion from int to float.src/main/java/com/paneedah/mwc/models/ACRStock.java (2)
64-95: Standardize ModelBox Numeric Parameters
Across numerousModelBoxconstructor calls the whole‑number parameters previously written as0.0Fhave been replaced with0. This change removes redundant float formatting and brings consistency to model dimension definitions. Please double‑check that no unintended shifts in model geometry occur.
100-361: Uniform Rotation Angle Declarations
Subsequent calls (including those tosetRotationAngle(...)and additionalModelBoxadditions in child model renderers) have similarly replaced float literals (like0.0F) with integer literals (0) for whole numbers. This overall cleanup is in line with the PR objectives.src/main/java/com/paneedah/mwc/items/guns/P90Factory.java (3)
187-191: Attachment Scaling Consistency
Within thewithCompatibleAttachment(Attachments.NightRaider, …)block the callGL11.glScaled(1, 1, 1);now uses integer literals instead of
1.0F, 1.0F, 1.0F. This change complies with the goal of removing unnecessary float suffixes and improves clarity.
374-390: Refined First-Person Positioning Scale
The first-person positioning transform now specifies the scale as.withScale(3, 3, 3);rather than using
3.0Fvalues. In addition, the left-hand positioning block now reads.withScale(2.6F, 2.6F, 4)(with the third parameter cleaned up to an integer). These modifications standardize the representation of scale factors while preserving the intended non‑integral values where needed.
599-604: Consistent Scale in Hand Positioning Modifications
In the block under.withFirstPersonHandPositioningModifying(…)the scale call is updated to use.withScale(2.6F, 2.6F, 4)in place of a float literal for the whole number. This matches the applied cleanup across the file.src/main/java/com/paneedah/mwc/items/guns/AUGFactory.java (1)
525-525: Improved code readability by removing redundant float suffixesThese changes simplify the code by replacing floating-point literals with integer literals where the fractional part is zero (e.g.,
3.0F→3,0.0f→0). This makes the code cleaner while maintaining identical functionality since Java automatically converts integers to floats when needed.Also applies to: 534-534, 676-679, 688-691, 700-703, 712-715, 724-727, 736-739, 750-750, 778-778, 819-819, 557-557
src/main/java/com/paneedah/mwc/items/guns/FiveSevenFactory.java (1)
156-156: Simplified numeric literals for better readabilityThe changes replace floating-point literals with integer literals where the fractional part is zero (e.g.,
3.0F→3,4.0F→4), making the code cleaner while preserving identical functionality.Also applies to: 231-231, 249-249
src/main/java/com/paneedah/mwc/items/guns/G3Factory.java (1)
381-381: Removed unnecessary float suffixes for better code clarityThese changes consistently simplify numeric literals by removing redundant float suffixes where the fractional part is zero. This improves readability while maintaining identical functionality since Java automatically converts integers to floats in these contexts.
Also applies to: 390-390, 398-398, 632-632
src/main/java/com/paneedah/mwc/items/guns/UziFactory.java (1)
170-170: Simplified numeric literals for better code consistencyThe changes replace floating-point literals with integer literals where appropriate (e.g.,
3.0F→3,4.0F→4). This aligns with the PR's goal of removing unnecessary float declarations and improves code readability without affecting functionality.Also applies to: 179-179, 331-331, 349-349
src/main/java/com/paneedah/mwc/items/guns/CZ805BrenFactory.java (1)
120-120: Appropriate conversion of floating literals to integer literals.The changes in this file are consistent with the PR objective of standardizing numerical representations by removing unnecessary float declarations.
Also applies to: 139-139, 244-244, 358-358, 367-367, 455-455, 479-479, 582-582
src/main/java/com/paneedah/mwc/models/ACOG.java (1)
189-189: Consistently simplified numerical representations.The modifications standardize numerical literals by replacing unnecessary float declarations (like
0.0F) with integer literals (0). This improves code readability while maintaining the same functionality, as Java automatically converts between numeric types as needed.Also applies to: 195-197, 203-204, 227-228, 233-234, 245-246, 469-470, 583-584, 789-790, 807-807, 831-831, 1026-1029, 1059-1061, 1134-1135, 1146-1147, 1152-1153, 1158-1159, 1164-1165, 1170-1171, 1176-1177, 1212-1213
src/main/java/com/paneedah/mwc/items/guns/S710TricunFactory.java (5)
70-70: Good simplification of floating-point parameter.Removing unnecessary floating-point suffix for whole number values improves code readability while maintaining the same functionality.
114-114: Clean transformation parameter update.Good conversion from
0.0fto0for y-coordinate parameter - simplifies the code without changing behavior.
458-458: Good simplification of scale parameters.Converting from
3.0F, 3.0F, 3.0Fto3, 3, 3improves readability while maintaining identical functionality.
467-467: Good parameter cleanup.Well-executed change from
2.6F, 2.6F, 4.0Fto2.6F, 2.6F, 4- removes the unnecessary float suffix for the third parameter.
678-678: Good parameter cleanup in modifying handler.Good consistency in replacing
4.0Fwith4across the codebase, aligned with the PR objectives.src/main/java/com/paneedah/mwc/models/ACRPolymerHandguard.java (4)
47-57: Appropriate simplification of ModelBox parameters.Good cleanup of multiple
ModelBoxconstructor parameters, converting0.0Fto0consistently across the cubeList declarations. This improves code readability without changing functionality.
62-63: Clean simplification of rotation angles.Good conversion of
0.0Fto0for rotation parameters in thesetRotationAnglecall, maintaining functionality while improving readability.
68-69: Consistent parameter simplification.Continuing the pattern of removing unnecessary float declarations consistently through the file.
74-75: Well-executed rotation angle parameter simplification.The changes consistently replace
0.0Fwith0across all rotation angle parameters throughout the file, demonstrating good attention to detail while maintaining code functionality.Also applies to: 80-81, 86-87, 93-94, 100-101, 113-114, 119-120, 126-127, 146-148, 153-154, 159-169, 173-174, 179-181, 186-187, 192-193, 198-199, 204-205, 210-211, 216-217, 222-223, 228-229
src/main/java/com/paneedah/mwc/items/guns/PythonFactory.java (5)
79-79: Good transformation parameter cleanup.Appropriate conversion from
-3.0Fto-3for the z-coordinate parameter in theglTranslatefcall.
112-112: Well-executed scale parameter simplification.Simplified
withScale(3.0F, 3.0F, 3.0F)towithScale(3, 3, 3)improves code clarity while maintaining functionality.
141-141: Good translation parameter cleanup.Simplified z-coordinate parameter from floating-point to integer format in the
glTranslatefcall.
181-181: Good scale parameter cleanup.Replaced
4.0Fwith4in the scale parameters while maintaining other fractional values.
199-199: Consistent parameter simplification.Maintained consistency by applying the same cleanup pattern to all similar parameters in the file.
src/main/java/com/paneedah/mwc/items/guns/M82Factory.java (4)
291-291: Good scale parameter simplification.Simplified
withScale(3.0F, 3.0F, 3.0F)towithScale(3, 3, 3)for cleaner code while maintaining functionality.
300-301: Consistent parameter cleanup.Good replacement of
4.0Fwith4in the z-scale parameter for left hand positioning.
308-309: Good scale parameter simplification.Converting from
3.0F, 3.0F, 3.0Fto3, 3, 3maintains consistency with the PR objective.
539-539: Consistent parameter simplification throughout the file.Continued the pattern of replacing
4.0Fwith4in hand positioning parameters, maintaining consistency across the codebase.src/main/java/com/paneedah/mwc/items/guns/MalyukFactory.java (14)
100-100: Consistent floating-point literal replacement to integerThe change from
GL11.glTranslatef(0f, 0.35f, 3.0f)toGL11.glTranslatef(0f, 0.35f, 3)maintains functionality while following the code style guidelines to use integer literals instead of forcing.0fnotation for whole numbers.
104-104: Consistent floating-point literal replacement to integerSimilar replacement of
.0fto integer literal for the Z parameter in the translation function. This change is consistent with the PR's goal of removing unnecessary float declarations.
109-109: Consistent floating-point literal replacement to integerSame pattern of simplifying
3.0fto3for the Z parameter in the translation function, making the code cleaner while maintaining identical behavior.
121-121: Consistent floating-point literal replacement to integerChanged the third parameter in
glTranslateffrom0.0fto0, which simplifies the code while maintaining the same value.
185-185: Consistent floating-point literal replacement to integerSimplified
GL11.glTranslatef(-0.06F, -1.18F, -1.0F)toGL11.glTranslatef(-0.06F, -1.18F, -1)by removing the unnecessary trailing.0Ffor the whole number value.
194-194: Consistent floating-point literal replacement to integerSimplified the Z parameter from
-1.0Fto-1in theglTranslatefcall, maintaining consistent style throughout the codebase.
203-203: Consistent floating-point literal replacement to integerReplaced
-1.0Fwith-1in the Z parameter of the translation function, adhering to the cleaner code style established in this PR.
212-212: Consistent floating-point literal replacement to integerSame pattern of simplifying
-1.0Fto-1for the Z parameter, maintaining consistency across the codebase.
236-236: Consistent floating-point literal replacement to integerChanged translation Z parameter from
-1.0Fto-1, following the same pattern as other changes in this file.
287-287: Consistent floating-point literal replacement to integerReplaced
-2.0Fwith-2in the VGrip translation, maintaining consistent use of integer literals when possible.
329-329: Consistent floating-point literal replacement to integerSimplified
.withScale(3.0F, 3.0F, 3.0F)to.withScale(3, 3, 3)for cleaner code while maintaining identical functionality.
338-338: Consistent floating-point literal replacement to integerChanged
.withScale(2.8F, 2.8F, 4.0F)to.withScale(2.8F, 2.8F, 4), removing the trailing.0Ffrom the third parameter.
497-498: Consistent floating-point literal replacement to integerMultiple instances of simplifying
.0fto integers in the zoom positioning adjustments, maintaining consistent integer usage for whole numbers across the file.Also applies to: 509-510, 521-522, 527-534
587-587: Consistent floating-point literal replacement to integerSimplified
.withScale(2.6F, 2.6F, 4.0F)to.withScale(2.6F, 2.6F, 4)in the first-person hand positioning, removing unnecessary.0Fnotation.src/main/java/com/paneedah/mwc/items/guns/APC9Factory.java (6)
145-145: Consistent floating-point literal replacement to integerChanged
-2.0Fto-2in the translation function, simplifying the code while maintaining the same value.
339-339: Consistent floating-point literal replacement to integerSimplified
.withScale(3.0F, 3.0F, 3.0F)to.withScale(3, 3, 3)for cleaner code while maintaining identical functionality.
348-348: Consistent floating-point literal replacement to integerChanged
.withScale(2.6F, 2.6F, 4.0F)to.withScale(2.6F, 2.6F, 4), removing the trailing.0Ffrom the third parameter.
356-357: Consistent floating-point literal replacement to integerTwo consecutive lines with
.withScale(3.0F, 3.0F, 3.0F)changed to.withScale(3, 3, 3), improving code readability by using simpler integer representation.
507-507: Consistent floating-point literal replacement to integerReplaced
0.0fwith just0inGL11.glTranslatef(0F, 0, 1f), continuing the pattern of simplifying float notation.
587-587: Consistent floating-point literal replacement to integerSimplified
.withScale(2.6F, 2.6F, 4.0F)to.withScale(2.6F, 2.6F, 4)in the first-person hand positioning, removing unnecessary.0Fnotation.src/main/java/com/paneedah/mwc/models/ACRPrecisionHandguard.java (8)
31-42: Consistent floating-point literal replacement to integerMultiple
ModelBoxconstructor calls have been updated to use0instead of0.0Ffor the last parameter, which simplifies the code while maintaining the same functionality. This change is consistent across all model box definitions in this file.
83-83: Consistent floating-point literal replacement to integerChanged
setRotationAngle(ACR2_r1, 0.0F, 0.0F, 0.9295F)tosetRotationAngle(ACR2_r1, 0, 0, 0.9295F), replacing zero float values with integer zeros.
84-86: Consistent floating-point literal replacement to integerMultiple
cubeList.addcalls updated to use0instead of0.0Ffor the last parameter in theModelBoxconstructor, maintaining consistency with the overall code style changes in this PR.
91-97: Consistent floating-point literal replacement to integerThe rotation angle and multiple
ModelBoxconstructor calls updated to use integer0instead of float0.0F, making the code cleaner while maintaining identical behavior.
101-114: Consistent floating-point literal replacement to integerSame pattern of simplifying rotation angles and
ModelBoxparameters from0.0Fto0applied consistently throughout this section.
119-145: Consistent floating-point literal replacement to integerMultiple model transformations updated to use
0rather than0.0Ffor both rotation angles and the last parameter of theModelBoxconstructor, maintaining a consistent style throughout the file.
150-160: Consistent floating-point literal replacement to integerSame pattern of simplification applied to rotation angles and
ModelBoxparameters in the bone2_r1 model segment.
165-229: Consistent floating-point literal replacement to integerExtensive set of model box definitions with the same pattern of replacing
0.0Fwith0for the last parameter in allModelBoxconstructor calls, maintaining consistency throughout the entire model definition.src/main/java/com/paneedah/mwc/asm/Interceptors.java (12)
79-81: Consistent floating-point literal replacement to integerChanged condition from
authenticFOV != 0.0ftoauthenticFOV != 0andMC.gameSettings.fovSetting == 80.0FtoMC.gameSettings.fovSetting == 80, simplifying the number representation while maintaining identical behavior.
97-99: Consistent floating-point literal replacement to integerFOV setting comparison changed from
80.0Fto80, and assignment ofauthenticFOV = 0.0ftoauthenticFOV = 0, following the pattern of using integers where possible.
155-155: Consistent floating-point literal replacement to integerChanged rotation function from
GL11.glRotatef(-roll, 0.0f, 0.0f, 1.0f)toGL11.glRotatef(-roll, 0, 0, 1), simplifying the zeros while maintaining the same functionality.
397-397: Consistent floating-point literal replacement to integerChanged scalar initialization from
float scalar = 0.0ftofloat scalar = 0, making the code cleaner while retaining identical functionality.
423-423: Consistent floating-point literal replacement to integerChanged scale multiplier initialization from
float sMult = 1.0ftofloat sMult = 1, following the pattern of simplifying float literals where possible.
433-436: Consistent floating-point literal replacement to integerMultiple changes to GL transformation calls, replacing integer values with
.0fsuffix with simple integers, making the code cleaner while maintaining the same rendering behavior.
458-462: Consistent floating-point literal replacement to integerMultiple
GL11.glTranslatefandGL11.glRotatefcalls updated to use integers where whole numbers were previously represented with.0fsuffix, maintaining identical functionality with cleaner code.
483-484: Consistent floating-point literal replacement to integerRotation and scale parameters simplified from floating point with
.0fsuffix to integers where possible, following the consistent pattern throughout this PR.
524-524: Consistent floating-point literal replacement to integerChanged amplitude initialization from
float appliedAmplitude = 0.0ftofloat appliedAmplitude = 0, simplifying the number representation.
602-604: Consistent floating-point literal replacement to integerCondition and rotation value simplified from floating point with
.0fsuffix to integers where appropriate, maintaining the same behavior with cleaner code.
607-609: Consistent floating-point literal replacement to integerComparison operator changed from
f < 0.0Ftof < 0, simplifying the code while maintaining identical functionality.
614-624: Consistent floating-point literal replacement to integerMultiple
GL11.glRotatefcalls updated to use integers for parameters that represent whole numbers, eliminating unnecessary.0fsuffixes while maintaining identical behavior.src/main/java/com/paneedah/mwc/items/guns/M249Factory.java (1)
81-81: LGTM! Proper simplification of float literals.These changes consistently replace floating-point literals (like
0.0F,-4.0F) with integer literals (0,-4) where the fractional part is zero. Since these methods accept float parameters, the integers will be implicitly converted to floats at compile time with no change in functionality.This simplification aligns with the PR objective of removing unnecessary float declarations that use the
.0fformat for clarity and simplicity.Also applies to: 87-87, 96-96, 238-238, 247-247, 256-256, 278-278, 287-287, 296-296, 305-305, 334-334, 338-338, 369-369, 378-378, 528-528
src/main/java/com/paneedah/mwc/entities/Entities.java (1)
46-47: LGTM! Simplified entity parameters correctly.These changes effectively replace floating-point literals with integer literals in the AI task configurations for various entities. Since the methods accept float parameters but the values have no fractional part, this simplification is appropriate and maintains identical functionality.
This cleanup supports the PR's goal of enhancing code clarity by removing unnecessary float specifications.
Also applies to: 49-49, 97-98, 100-100, 135-135, 142-143, 185-185, 192-193, 235-235, 242-243
src/main/java/com/paneedah/mwc/models/ACRSquareDropHandguard.java (1)
44-44: LGTM! Consistent application of float literal simplification.These changes replace floating-point literals (like
0.0F) with integer literals (0) throughout model construction. The changes affect:
ModelBoxconstructor parameterssetRotationAnglemethod parameterssetRotationPointmethod parametersSince all these methods expect float parameters and these values have no fractional part, this simplification maintains identical rendering behavior while improving code readability.
Also applies to: 49-82, 83-91, 96-103, 108-109, 122-123, 128-130, 135-137, 142-144, 149-151, 156-158, 163-165, 170-172, 177-179, 184-186, 191-193, 198-200, 205-207, 212-214, 217-220, 225-235, 238-250
src/main/java/com/paneedah/mwc/items/guns/MAC10Factory.java (1)
106-106: LGTM! Successful float literal simplification.These changes replace floating-point literals (such as
-1.0F,-0.0F) with integer literals (-1,-0) in GL11 transformations and scale operations. This maintains identical functionality while improving code readability.Note: Even the change from
-0.0Fto-0is safe despite the technical difference in floating-point representation, as it won't affect the rendering behavior in this context.Also applies to: 127-127, 310-310, 562-562, 580-580
src/main/java/com/paneedah/mwc/models/AACHoneyBadgerReceiver.java (1)
1284-1385: Render Method: Intentional Commenting and Unchanged Logic
Therendermethod mostly contains commented-out calls (presumably for debugging or selective rendering) and a few active render calls. There are no functional changes here, and the commented code appears to be left intentionally. No action is required for this section.src/main/java/com/paneedah/mwc/items/guns/FMG9Factory.java (10)
165-167: Standardize Numeric Literal in Translation Call
Replacing-0.0Fwith-0improves clarity by using an integer literal for a whole-number value. This change meets the PR objective of removing unnecessary float declarations.
175-177: Consistent Literal Cleanup in Holographic Attachment
The update changes the translation parameter from-0.0Fto-0, ensuring uniform numeric representation for whole numbers in similar attachment transformations.
185-187: Refined Translation Parameter Format for EotechHybrid2 Attachment
Changing-0.0Fto-0standardizes the numeric literal usage, enhancing consistency and readability.
248-250: Selective Literal Cleanup in Silencer9mm Attachment
This change retains the fractional precision for non-whole numbers (e.g.,-0.165Fand-4.7F) while using an integer literal for the whole number (-1). It accurately applies the cleanup strategy without affecting numerical accuracy.
278-278: Simplified Scale Parameters
Converting scale values from3.0Fto3improves readability by using an integer representation for whole-number values. This is in full alignment with the cleanup guidelines.
386-387: Refined Translation Literals for MicroReflex Attachment
The translation call now uses0instead of0.0Ffor whole-number values, streamlining numeric literal formatting. This update is consistent with the PR’s objective.
391-392: Cleaned Up Zero Literal in NightRaider Attachment
Changing the literal from0.0Fto0ensures that whole-number values are represented uniformly throughout the code.
446-447: Consistent Numeric Format in MicroT1 Attachment
The translation call has been updated to use simplified numeric literals, removing unnecessary float precision for values that are whole numbers.
451-452: Standardized Translation Literals for AimpointCompM5 Attachment
Replacing the redundant float notation in the translation call (from0.0Fto0) improves consistency across attachments.
483-483: Refactored Scale Literal in Hand Positioning
Modifying the scale parameters to2.6F, 2.6F, 4removes the unnecessary decimal for the whole number, which streamlines the code while preserving intended behavior.
|
Is this still relevant? |
3 participants
📝 Description
This removes the crazy amount of floats that use .0f when it is unneeded
🎯 Goals
❌ Non Goals
🚦 Testing
It builds, and I did a little bit of fights against some terrorists to make sure everything worked correctly
⏮️ Backwards Compatibility
N/A
📖 Added to documentation?