Update nginx.conf - #56
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b3da348b9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ssl_certificate /etc/nginx/certs/${OE_NGINX_CERT}; | ||
| ssl_certificate_key /etc/nginx/keys/${OE_NGINX_KEY}; | ||
| listen 80; |
There was a problem hiding this comment.
Keep the proxy listening on HTTPS for compose users
In the default docker-compose deployment, the proxy service still publishes 443:443 and the README's documented entry point is https://localhost/, but this config now only binds nginx to port 80. Anyone running the repository as documented, without an external Traefik/Dokploy TLS terminator, will get connection failures on HTTPS instead of the OpenELIS frontend. Please either retain the SSL listener for the compose path or split/update the deployment config so the HTTP-only listener is only used behind Traefik.
Useful? React with 👍 / 👎.
No description provided.