-
Notifications
You must be signed in to change notification settings - Fork 29
Update nginx.conf #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zyrogX
wants to merge
1
commit into
DIGI-UW:main
Choose a base branch
from
zyrogX:patch-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,61 +1,49 @@ | ||
| # ===================================================================== | ||
| # OpenELIS internal reverse proxy — HTTP-only build for Dokploy | ||
| # | ||
| # Dokploy's Traefik terminates public TLS (Let's Encrypt) and forwards | ||
| # plain HTTP to this container on port 80. This proxy then stitches the | ||
| # app together: / -> React frontend | /api/ -> Tomcat backend (8443). | ||
| # The nginx->backend hop stays HTTPS internally with the self-signed | ||
| # certs from the certgen service (nginx does not verify upstream certs). | ||
| # ===================================================================== | ||
|
|
||
| worker_processes 1; | ||
|
|
||
| events { worker_connections 1024; } | ||
|
|
||
| http { | ||
| server { | ||
| listen 80; | ||
| server_name _; | ||
| ##### Comment to run on HTTP | ||
| return 301 https://$host$request_uri; | ||
|
|
||
| ##### Uncomment to run on HTTP | ||
| # location / { | ||
| # proxy_pass http://frontend.openelis.org; | ||
| # proxy_redirect off; | ||
|
|
||
| # proxy_set_header Host $host; | ||
| # proxy_set_header X-Real-IP $remote_addr; | ||
| # proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for; | ||
| # proxy_set_header X-Forwarded-Proto $scheme; | ||
| # } | ||
| # location /api/ { | ||
| # proxy_pass https://oe.openelis.org:8443/api/; | ||
| # proxy_redirect off; | ||
|
|
||
| # proxy_set_header Host $host; | ||
| # proxy_set_header X-Real-IP $remote_addr; | ||
| # proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for; | ||
| # proxy_set_header X-Forwarded-Host $server_name; | ||
| # proxy_set_header X-Forwarded-Proto $scheme; | ||
| # } | ||
| # TLS is terminated at Traefik. Trust its X-Forwarded-Proto so the | ||
| # app generates correct https URLs; default to https if the header | ||
| # is missing (it will always be present in normal operation). | ||
| map $http_x_forwarded_proto $fwd_proto { | ||
| default $http_x_forwarded_proto; | ||
| "" https; | ||
| } | ||
|
|
||
| server { | ||
| listen [::]:443 ssl; | ||
| listen 443 ssl default; | ||
| server_name __; | ||
|
|
||
| ssl_certificate /etc/nginx/certs/${OE_NGINX_CERT}; | ||
| ssl_certificate_key /etc/nginx/keys/${OE_NGINX_KEY}; | ||
| listen 80; | ||
| server_name _; | ||
|
|
||
| proxy_set_header X-Forwarded-For $proxy_protocol_addr; # To forward the original client's IP address | ||
| proxy_set_header X-Forwarded-Proto $scheme; # to forward the original protocol (HTTP or HTTPS) | ||
| proxy_set_header Host $host; # to forward the original host requested by the client | ||
| absolute_redirect off; | ||
|
|
||
| absolute_redirect off; | ||
| proxy_set_header X-Forwarded-Proto $fwd_proto; | ||
| proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for; | ||
| proxy_set_header Host $host; | ||
|
|
||
| location / { | ||
| proxy_pass http://frontend.openelis.org; | ||
| proxy_redirect off; | ||
| proxy_pass http://frontend.openelis.org; | ||
| proxy_redirect off; | ||
| } | ||
|
|
||
| location /api/ { | ||
| proxy_pass https://oe.openelis.org:8443/api/; | ||
| proxy_redirect off; | ||
| proxy_set_header Host $host; | ||
| proxy_set_header X-Real-IP $remote_addr; | ||
| proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for; | ||
| proxy_set_header X-Forwarded-Host $server_name; | ||
| proxy_set_header Host $host; | ||
| proxy_set_header X-Real-IP $remote_addr; | ||
| proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for; | ||
| proxy_set_header X-Forwarded-Host $host; | ||
| proxy_set_header X-Forwarded-Proto $fwd_proto; | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the default docker-compose deployment, the proxy service still publishes
443:443and the README's documented entry point ishttps://localhost/, but this config now only binds nginx to port 80. Anyone running the repository as documented, without an external Traefik/Dokploy TLS terminator, will get connection failures on HTTPS instead of the OpenELIS frontend. Please either retain the SSL listener for the compose path or split/update the deployment config so the HTTP-only listener is only used behind Traefik.Useful? React with 👍 / 👎.