Correct T_pSX in moist air to avoid simulation error when size X is 1#303
Open
CorentinLepais wants to merge 1 commit intoDLR-SR:mainfrom
Open
Correct T_pSX in moist air to avoid simulation error when size X is 1#303CorentinLepais wants to merge 1 commit intoDLR-SR:mainfrom
CorentinLepais wants to merge 1 commit intoDLR-SR:mainfrom
Conversation
Contributor
Author
|
Regression tests ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of the function T_psX in Moist Air leads to a simulation error when using the function without providing the complete mass fraction X vector {X[Water],X[Air]}. The function has been updated to test the size of the input mass fraction vector X and re-calculate the mass fraction of air X[Air] if missing.
Closes #302