Skip to content

Correct T_pSX in moist air to avoid simulation error when size X is 1 #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CorentinLepais wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Correct T_pSX in moist air to avoid simulation error when size X is 1 #303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ThermofluidStream/Media/myMedia/Air/MoistAir.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1277,13 +1277,19 @@ end thermalConductivity;
end f_nonlinear;

algorithm
T := Modelica.Math.Nonlinear.solveOneNonlinearEquation(
function f_nonlinear(p=p, s=s, X=X[1:nX]), 190, 647);
if size(X, 1) == nX then
T := Modelica.Math.Nonlinear.solveOneNonlinearEquation(
function f_nonlinear(p=p, s=s, X=X), 190, 647);
else
T := Modelica.Math.Nonlinear.solveOneNonlinearEquation(
function f_nonlinear(p=p, s=s, X=cat(1,X[1:nXi],{1 - sum(X[1:nXi])})), 190, 647);
end if;
annotation (Documentation(info="<html>
Temperature is computed from pressure, specific entropy and composition via numerical inversion of function <a href=\"modelica://Modelica.Media.Air.MoistAir.s_pTX\">s_pTX</a>.
</html>",
revisions="<html>
<p>2012-01-12 Stefan Wischhusen: Initial Release.</p>
<p>2026-04-08 Corentin Lepais: Correct algorithm to add X[Air] to the vector X if size(X,1) is different from nX.</p>
</html>"));
end T_psX;

Expand Down
Loading