Add 12-hour datetime format parsing - #118
Open
hamzahchaudhry wants to merge 2 commits into
Open
Conversation
Signed-off-by: hamzah <hamzah.chaudhry@proton.me>
Signed-off-by: hamzah <hamzah.chaudhry@proton.me>
hamzahchaudhry
force-pushed
the
add-12-hour-dateformat
branch
from
June 4, 2026 03:26
546e63a to
4786345
Compare
lauft
approved these changes
Jul 23, 2026
lauft
left a comment
lauft
left a comment
Member
There was a problem hiding this comment.
LGTM.
But I think we also need to update the relevant documentation in Taskwarrior and Timewarrior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i: minimal 12-hour value, e.g.1or12I: zero-padded 12-hour value, e.g.01or12p: AM/PM marker, case-insensitive when parsingAmbiguous 12-hour inputs without
pare rejected, so1:30 PMis valid but1:30with a 12-hour format is not silently interpreted as AM or PM.GothenburgBitFactory/taskwarrior#3981