Skip to content

Improve MorpheusVirtualImageImplService#151

Open
davidray wants to merge 1 commit intov1.4.xfrom
MORPH-9674-improve-MorpheusVirtualImageImplService
Open

Improve MorpheusVirtualImageImplService#151
davidray wants to merge 1 commit intov1.4.xfrom
MORPH-9674-improve-MorpheusVirtualImageImplService

Conversation

@davidray
Copy link
Copy Markdown

Updates the plugin core to reflect the changes made to this service interface. It also adds a super-basic AGENTS.md to reduce the tokens used to find a JIRA ticket

Updates the plugin core to reflect the changes made to this service interface. It also adds a super-basic AGENTS.md to reduce the tokens used to find a JIRA ticket
Copilot AI review requested due to automatic review settings April 10, 2026 21:31
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the plugin API to deprecate cloud-scoped VirtualImage persistence methods in favor of the newer bulk CRUD APIs, and adds lightweight agent guidance for JIRA lookups.

Changes:

  • Deprecates save(List<VirtualImage>, Cloud) and create(...) overloads on MorpheusVirtualImageService in favor of bulkSave(List) / bulkCreate(List) / model-scoped create(...).
  • Adds AGENTS.md with a minimal JIRA configuration note to aid automated ticket lookups.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
morpheus-plugin-api/src/main/java/com/morpheusdata/core/MorpheusVirtualImageService.java Marks cloud-parameter CRUD overloads as deprecated and points callers toward bulk/model-scoped APIs.
AGENTS.md Adds minimal JIRA lookup configuration for agents.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

* @param virtualImage new VirtualImage to persist
* @param cloud the Cloud instance
* @return the VirtualImage
* @deprecated use {@link #create(com.morpheusdata.model.MorpheusModel)} instead
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Javadoc @deprecated link points to #create(com.morpheusdata.model.MorpheusModel), but this interface (and its parent MorpheusDataService) expose create(M item) which resolves here as create(VirtualImage). As written, the link likely won’t resolve in Javadoc generation. Update the link to reference the correct overload (e.g., #create(VirtualImage) / the inherited create(VirtualImage) method).

Suggested change
* @deprecated use {@link #create(com.morpheusdata.model.MorpheusModel)} instead
* @deprecated use {@link #create(VirtualImage)} instead

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants