Skip to content

Improve MorpheusVirtualImageImplService #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidray wants to merge 1 commit into
base: v1.4.x
Choose a base branch
from
Open

Improve MorpheusVirtualImageImplService #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# AGENTS

## JIRA configuration
The Atlassian cloud ID is `b26ad273-0621-4dd6-8915-78cfbe11048e` for `hpe.atlassian.net`. Use this whenever looking up JIRA cards that start with "MORPH-"
6 changes: 6 additions & 0 deletions morpheus-plugin-api/src/main/java/com/morpheusdata/core/MorpheusVirtualImageService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,9 @@ public interface MorpheusVirtualImageService extends MorpheusDataService<Virtual
* @param virtualImages updated VirtualImages
* @param cloud the Cloud instance
* @return success
* @deprecated use {@link #bulkSave(List)} instead
*/
@Deprecated(since="1.4.0")
Single<Boolean> save(List<VirtualImage> virtualImages, Cloud cloud);

/**
Expand All @@ -168,7 +170,9 @@ public interface MorpheusVirtualImageService extends MorpheusDataService<Virtual
* @param virtualImages new VirtualImages to persist
* @param cloud the Cloud instance
* @return success
* @deprecated use {@link #bulkCreate(List)} instead
*/
@Deprecated(since="1.4.0")
Single<Boolean> create(List<VirtualImage> virtualImages, Cloud cloud);

/**
Expand All @@ -178,7 +182,9 @@ public interface MorpheusVirtualImageService extends MorpheusDataService<Virtual
* @param virtualImage new VirtualImage to persist
* @param cloud the Cloud instance
* @return the VirtualImage
* @deprecated use {@link #create(com.morpheusdata.model.MorpheusModel)} instead
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Javadoc @deprecated link points to #create(com.morpheusdata.model.MorpheusModel), but this interface (and its parent MorpheusDataService) expose create(M item) which resolves here as create(VirtualImage). As written, the link likely won’t resolve in Javadoc generation. Update the link to reference the correct overload (e.g., #create(VirtualImage) / the inherited create(VirtualImage) method).

Suggested change
* @deprecated use {@link #create(com.morpheusdata.model.MorpheusModel)} instead
* @deprecated use {@link #create(VirtualImage)} instead

Copilot uses AI. Check for mistakes.
*/
@Deprecated(since="1.4.0")
Single<VirtualImage> create(VirtualImage virtualImage, Cloud cloud);

/**
Expand Down
Loading