info: show other installed versions#22241
Conversation
and
both output the same information. I think if we want to highlight other versions it should avoid duplication. Also as a general note @HaraldNordgren: I'm getting concerned that we may make |
I don't quite follow this? Do you mean the star for a linked formula, it's quite hidden imo, not sure how many users look here. It's there for a formula without any siblings as well. So for me I would consider dropping it:
Could be true! Even if I'm spraying PR's at the moment, these are things I have had in the back of my head for the 10 or so years I've been using Homebrew and teaching my team to use brew, so not just randomly adding stuff 🤗 |
|
Or do you mean the location of the keg itself? Yes, that also seems quite specific and not necessarily useful unless the user wants It doesn't tell me if it's linked or not. |
I mean that this section will output multiple kegs for e.g.
Ok good to know 👍🏻 |
@MikeMcQuaid Ah, so you mean collapse the new Maybe, but not necessarily clearer for me as a user. If so, we should add some explanatory text as well! |
Yeh. Or we make that part of the installed versions section and display similar information. I'd like to avoid repetition between sections that are relatively far apart from one another. |
@MikeMcQuaid Moving it down to the installed versions section would look nicer I think, the upper section is quite crowded. However, one complication is that I was not going to show that section when there are no siblings. We need to have a solution that works for any formula. |
Yeh. I think the "installed versions" language makes sense even for the current output? what do you think? |
|
@MikeMcQuaid Updated, looks much nicer! I renamed the section to "Installed" so it wouldn't look weird for formulae without siblings: |
6293853 to
9aa1f4c
Compare
0a81675 to
02cefbb
Compare
4c7272e to
1c27a6f
Compare
|
@MikeMcQuaid Here is an output that I like.
|
|
Big output for Python on my machine, but I think it's correct: |
a208399 to
e05bc1a
Compare
|
@MikeMcQuaid Can I get some review here please? |
|
@HaraldNordgren yes, please give me a bit 🙇🏻 |
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Thanks, sorry for delay. Almost there!
a667b1b to
451306c
Compare
|
@MikeMcQuaid Thanks a lot! Pushed a new version and squashed all commits. |
38519d3 to
d2c7401
Compare
MikeMcQuaid
left a comment
There was a problem hiding this comment.
@HaraldNordgren Came to ✅ based on local testing but: one more tiny thing, sorry! This is way better, thanks for your hard work and patience here.
d2c7401 to
4b21838
Compare
4b21838 to
a2b77dc
Compare
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Thanks again @HaraldNordgren!
Give user info about sibling formulae:
brew lgtm(style, typechecking and tests) with your changes locally?Claud Code, Extra High