Handle additional types in ztypeName (#328) (cherry-pick from main) - #332
Merged
Conversation
* Add abbreviations for few data types * Add handling for additional data types in ztypeName
|
perrymanmd
approved these changes
Nov 6, 2025
perrymanmd
left a comment
perrymanmd
left a comment
Contributor
There was a problem hiding this comment.
Deal with comment on ztypeName.c as you wish.
| else if (recordType == DATA_TYPE_UGT) { | ||
| if (boolAbbreviation) return DATA_TYPE_ABBR_400; | ||
| return DATA_TYPE_400; | ||
| } |
Contributor
There was a problem hiding this comment.
Why not
return boolAbbreviation ? DATA_TYPE_ABBR_400 : DATA_TYPE_400;
I would also suggest using switch(recordType) { instead of chaining else if blocks.
Just stylistic, doesn't affect my approval the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add abbreviations for few data types
Add handling for additional data types in ztypeName