chore: upgrade GitHub Actions from Node 20 to Node 24#188
Conversation
mcollins-ttd
left a comment
mcollins-ttd
left a comment
There was a problem hiding this comment.
This PR correctly upgrades GitHub Actions to versions that ship Node 24 support, using SHA pinning with version comments — a solid security and compatibility practice. The major version jumps (checkout v2→v6, metadata-action v4→v6, build-push-action v5→v7) are expected given the age of some of the pinned versions. One pre-existing deprecated command (set-output) in docker-publish.yaml is worth flagging for a follow-up, but it is not introduced by this PR.
| uses: actions/setup-node@v4 | ||
| uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 | ||
| with: | ||
| node-version: '20.11.0' |
There was a problem hiding this comment.
Claude Review: node-version: '20.11.0' here controls the Node version used to build and test the application code, which is intentionally distinct from the action runner's Node runtime being upgraded by this PR. This is correct as-is — no change needed unless the app itself is being migrated to Node 24.
| - name: Get Package Version | ||
| id: version | ||
| run: | | ||
| echo "::set-output name=package_version::$(cat package.json | jq -r '.version')" |
There was a problem hiding this comment.
Claude Review: echo "::set-output name=package_version::..." is a pre-existing use of the deprecated set-output workflow command (replaced by $GITHUB_OUTPUT in 2022). Not introduced by this PR, but since this file is being touched it would be a good opportunity to update it to: echo "package_version=$(cat package.json | jq -r .version)" >> $GITHUB_OUTPUT
2 participants
Node 20 is being deprecated on GitHub Actions runners. Starting June 16, 2026, runners will use Node 24 by default.
This PR upgrades outdated action references in this repo to the latest released version that ships Node 24 support, pinned to its commit SHA. Each action's node version is determined by reading its
action.ymlat the pinned ref.See: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/