-
Notifications
You must be signed in to change notification settings - Fork 7
chore: upgrade GitHub Actions from Node 20 to Node 24 #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,26 +14,26 @@ jobs: | |
| packages: write | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 | ||
| - name: Get Package Version | ||
| id: version | ||
| run: | | ||
| echo "::set-output name=package_version::$(cat package.json | jq -r '.version')" | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Claude Review: |
||
| - name: Log in to the Container registry | ||
| uses: docker/login-action@465a07811f14bebb1938fbed4728c6a1ff8901fc # v2 | ||
| uses: docker/login-action@650006c6eb7dba73a995cc03b0b2d7f5ca915bee # v4.2.0 | ||
| with: | ||
| registry: ${{ env.REGISTRY }} | ||
| username: ${{ github.actor }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} | ||
| - name: Extract metadata (tags, labels) for Docker (UID2) | ||
| id: meta-uid2 | ||
| uses: docker/metadata-action@818d4b7b91585d195f67373fd9cb0332e31a7175 # v4 | ||
| uses: docker/metadata-action@80c7e94dd9b9319bd5eb7a0e0fe9291e23a2a2e9 # v6.1.0 | ||
| with: | ||
| images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME_UID2 }} | ||
| tags: | | ||
| type=sha,prefix=${{ steps.version.outputs.package_version }}-,format=short | ||
| - name: Build and push Docker image (UID2) | ||
| uses: docker/build-push-action@ca052bb54ab0790a636c9b5f226502c73d547a25 # v5 | ||
| uses: docker/build-push-action@f9f3042f7e2789586610d6e8b85c8f03e5195baf # v7.2.0 | ||
| with: | ||
| context: . | ||
| file: Dockerfile_uid2 | ||
|
|
@@ -43,13 +43,13 @@ jobs: | |
| labels: ${{ steps.meta-uid2.outputs.labels }} | ||
| - name: Extract metadata (tags, labels) for Docker (EUID) | ||
| id: meta-euid | ||
| uses: docker/metadata-action@818d4b7b91585d195f67373fd9cb0332e31a7175 # v4 | ||
| uses: docker/metadata-action@80c7e94dd9b9319bd5eb7a0e0fe9291e23a2a2e9 # v6.1.0 | ||
| with: | ||
| images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME_EUID }} | ||
| tags: | | ||
| type=sha,prefix=${{ steps.version.outputs.package_version }}-,format=short | ||
| - name: Build and push Docker image (EUID) | ||
| uses: docker/build-push-action@ca052bb54ab0790a636c9b5f226502c73d547a25 # v5 | ||
| uses: docker/build-push-action@f9f3042f7e2789586610d6e8b85c8f03e5195baf # v7.2.0 | ||
| with: | ||
| context: . | ||
| file: Dockerfile_euid | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Claude Review:
node-version: '20.11.0'here controls the Node version used to build and test the application code, which is intentionally distinct from the action runner's Node runtime being upgraded by this PR. This is correct as-is — no change needed unless the app itself is being migrated to Node 24.