Skip to content

Soften commanding phrasing in translation strings - #2632

Merged
HarelM merged 9 commits into
mainfrom
soften-translation-phrasing
Aug 11, 2026
Merged

Soften commanding phrasing in translation strings#2632
HarelM merged 9 commits into
mainfrom
soften-translation-phrasing

Conversation

@zstadler

@zstadler zstadler commented Aug 10, 2026

Copy link
Copy Markdown
Member

Summary

A few UI strings across the translation files use commanding/nagging phrasing ("you should...", "you need to...") that reads more aggressively than the rest of the app's neutral, friendly tone. This PR softens the wording while preserving the meaning, across all 5 locales (en-US, he, ru, es, ar).

Changes

1. "No traces" empty state — removed "you should really" nagging, reframed as a helpful note about why uploading helps.

2. "Add your description" prompt — removed "You should...!" imperative, now a plain instruction.

3. Login prompt for traces — removed "You need to", now leads with the action ("Log in to...").

4. Battery optimization instructions — removed "Please make sure... Go to..." stacked commands, now a single explanatory sentence framed around the benefit (reliable tracking).

Bonus (Arabic only): the "more than 10 routes" performance warning included an extra "يرجى حذف بعضهم" ("please delete some of them") not present in the English source or other locales. Removed to match the neutral, informational tone used elsewhere.

Notes

  • No user-facing behavior changes — text only.
  • Wording was checked against the existing tone of each locale file (e.g. Hebrew's existing softer phrasing was preserved and only lightly adjusted for consistency).
  • Punctuation uses plain hyphens throughout (no em/en dashes), consistent with the rest of the codebase's style.
  • Happy to adjust wording in any language based on maintainer feedback - my fluency is strongest in English; native speakers should sanity-check the other four.

@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.33%. Comparing base (00dc344) to head (96275f8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2632   +/-   ##
=======================================
  Coverage   91.33%   91.33%           
=======================================
  Files          85       85           
  Lines        8440     8440           
  Branches     1373     1373           
=======================================
  Hits         7709     7709           
  Misses        537      537           
  Partials      194      194           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@HarelM

HarelM commented Aug 10, 2026

Copy link
Copy Markdown
Member

Some keys are not aligned after this change, right?

@HarelM
HarelM merged commit ad9fe71 into main Aug 11, 2026
7 checks passed
@HarelM
HarelM deleted the soften-translation-phrasing branch August 11, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants