Compare all artists when doing dedup, not just primary#183
Open
zkornbluth wants to merge 1 commit intoJMPerez:masterfrom
Open
Compare all artists when doing dedup, not just primary#183zkornbluth wants to merge 1 commit intoJMPerez:masterfrom
zkornbluth wants to merge 1 commit intoJMPerez:masterfrom
Conversation
Fixes JMPerez#160. Now compares the full list of artists when deciding if tracks with different IDs are duplicates. Also displays the full list of artists for duplicate songs after processing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #160.
Now compares the full list of artists when deciding if tracks with different IDs are duplicates.
Also displays the full list of artists for duplicate songs after processing.
I also noticed the "Remove duplicates from this playlist" button moved. Looked this way before my changes. Wasn't sure if it was intentional so I left it as is. If not, that should be a new issue.
