Skip to content

Compare all artists when doing dedup, not just primary #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zkornbluth wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Compare all artists when doing dedup, not just primary #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/main.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ export default class Main extends React.Component<{
key={index}
reason={duplicate.reason}
trackName={duplicate.track.name}
trackArtistName={duplicate.track.artists[0].name}
trackArtistName={duplicate.track.artists.map(artist => artist.name).join(", ")}
/>
)
)}
Expand Down Expand Up @@ -278,7 +278,7 @@ export default class Main extends React.Component<{
key={index}
reason={duplicate.reason}
trackName={duplicate.track.name}
trackArtistName={duplicate.track.artists[0].name}
trackArtistName={duplicate.track.artists.map(artist => artist.name).join(", ")}
/>
))}
</DuplicateTrackList>
Expand Down
6 changes: 3 additions & 3 deletions dedup/deduplicator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@ class BaseDeduplicator {
if (track.id === null) return duplicates;
let reasonDuplicate: 'same-id' | 'same-name-artist' | null = null;
const seenNameAndArtistKey =
`${track.name}:${track.artists[0].name}`.toLowerCase();
`${track.name}:${track.artists.map(artist => artist.name).join(",")}`.toLowerCase();
if (track.id in seenIds) {
// if the two tracks have the same Spotify ID, they are duplicates
reasonDuplicate = 'same-id';
} else {
// if they have the same name, main artist, and roughly same duration
// we consider tem duplicates too
// if they have the same name, all artists, and roughly same duration
// we consider them duplicates too
if (seenNameAndArtistKey in seenNameAndArtist) {
// we check if _any_ of the previous durations is similar to the one we are checking
if (
Expand Down