fix: honor temperature_decimals in on-graph min/max labels - #58
Open
ProAdmin007 wants to merge 2 commits into
Open
fix: honor temperature_decimals in on-graph min/max labels#58ProAdmin007 wants to merge 2 commits into
ProAdmin007 wants to merge 2 commits into
Conversation
_formatGraphValue rounded temperature regardless of the option, so the min/max markers drawn on the graph stayed whole numbers while the value readout and tooltip showed a decimal. Split °C/°F out so the overlay is consistent with the rest of the display. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_formatGraphValue rounded temperature regardless of the option, so the min/max markers drawn on the graph stayed whole numbers while the value readout and tooltip showed a decimal. Split °C/°F out so the overlay is consistent with the rest of the display.
Claude mest up and did not add the button, Sorry needed to check first.