fix: Add VALUE to IdentifierOrSoftKey definition in spec docs#140
Open
Ashutosh0x wants to merge 1 commit into
Open
fix: Add VALUE to IdentifierOrSoftKey definition in spec docs#140Ashutosh0x wants to merge 1 commit into
Ashutosh0x wants to merge 1 commit into
Conversation
Add the missing VALUE soft keyword to both the IdentifierOrSoftKey
grammar rule and the lexical modifier definitions in syntax.md.
The VALUE token ('value') was already present in KotlinLexer.g4 (line 302
in IdentifierOrSoftKey, line 161 as a lexical modifier) but was missing
from the specification documentation.
Fixes Kotlin#128
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the missing
VALUEsoft keyword to both theIdentifierOrSoftKeygrammar rule and the lexical modifier definitions insyntax.md.Problem
As reported in #128, the
VALUEtoken is present inKotlinLexer.g4:VALUE: 'value';(lexical modifier definition)| VALUE(inIdentifierOrSoftKeyrule)However, it was missing from the specification documentation in
docs/src/md/kotlin.core/syntax.md.Changes
VALUEkeyword definition (grammar-rule-VALUE) in the lexical modifiers section, afterINNERVALUEto theIdentifierOrSoftKeyrule, beforeCONSTandSUSPENDBoth match the ordering in
KotlinLexer.g4.Fixes #128