Conversation
Collaborator
Author
Contributor
|
Ok let me have a look
…On Fri, Feb 14, 2020 at 7:54 PM Ruffin ***@***.***> wrote:
@ToniRV <https://github.com/ToniRV> , let me know if you have any
feedback on this and #3
<#3> , #4
<#4> . As they all build
onto of each other, and I prefer to get them merged before refactoring
further on the parser nodes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2?email_source=notifications&email_token=ACLGJI47COJ5XUGCAFBWI63RC44LXA5CNFSM4KUKNB52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL246OI#issuecomment-586534713>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACLGJI24L2GALVQXAQC2ONTRC44LXANCNFSM4KUKNB5Q>
.
|
ToniRV
approved these changes
Feb 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes common cmake setup for all later ROS2 kimera packages.