feat: include outputFacets and inputFacets in Dataset API responses#3106
Open
psaikaushik wants to merge 1 commit intoMarquezProject:mainfrom
Open
feat: include outputFacets and inputFacets in Dataset API responses#3106psaikaushik wants to merge 1 commit intoMarquezProject:mainfrom
outputFacets and inputFacets in Dataset API responses#3106psaikaushik wants to merge 1 commit intoMarquezProject:mainfrom
Conversation
Add 'output' type to the facet type filter in DatasetDao and DatasetVersionDao SQL queries. Previously, facets of type 'output' (e.g. OutputStatistics, DataQualityMetrics) were stored correctly but excluded from read queries. Affected queries: - DatasetDao.findDatasetByName - DatasetDao.findAll - DatasetVersionDao.findByUuid - DatasetVersionDao.findAll Closes MarquezProject#1746 Signed-off-by: Sai Kaushik Ponnekanti <psaikaushik@gmail.com>
Author
|
@wslulciuc , @davidjgoss : Can you please take a look and let me know. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
DatasetDaoandDatasetVersionDaoSQL queries to include facets of type'output'in API responses, in addition to the existing'dataset','unknown', and'input'types.Supersedes #3103 (recreated to fix DCO sign-off).
Closes #1746
Problem
Marquez stores
outputFacetsandinputFacetscorrectly in thedataset_facetstable. However, the read queries filtered with:This excluded
'output'type facets (e.g.,OutputStatistics) from API responses.Fix
Added
OR df.type ILIKE 'output'to the facet type filter in:DatasetDao.findDatasetByNameDatasetDao.findAllDatasetVersionDao.findByUuidDatasetVersionDao.findAllChecklist