Skip to content

feat: include outputFacets and inputFacets in Dataset API responses #3106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
psaikaushik wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: include outputFacets and inputFacets in Dataset API responses #3106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions api/src/main/java/marquez/db/DatasetDao.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ LEFT JOIN (
JSONB_AGG(df.facet ORDER BY df.lineage_event_time ASC) AS facets
FROM dataset_facets AS df
WHERE df.facet IS NOT NULL AND
(df.type ILIKE 'dataset' OR df.type ILIKE 'unknown' OR df.type ILIKE 'input') AND
(df.type ILIKE 'dataset' OR df.type ILIKE 'unknown' OR df.type ILIKE 'input' OR df.type ILIKE 'output') AND
df.dataset_uuid = (SELECT uuid FROM datasets WHERE name = :datasetName AND namespace_name = :namespaceName)
GROUP BY df.dataset_version_uuid
) f ON f.dataset_version_uuid = d.current_version_uuid
Expand Down Expand Up @@ -132,7 +132,8 @@ default void setFields(Dataset ds) {
WHERE df.facet IS NOT NULL
AND (df.type ILIKE 'dataset'
OR df.type ILIKE 'unknown'
OR df.type ILIKE 'input')
OR df.type ILIKE 'input'
OR df.type ILIKE 'output')
AND df.dataset_uuid IN
(SELECT UUID
FROM datasets_view
Expand Down
4 changes: 2 additions & 2 deletions api/src/main/java/marquez/db/DatasetVersionDao.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ WITH selected_dataset_versions AS (
), selected_dataset_version_facets AS (
SELECT dv.uuid, dv.dataset_name, dv.namespace_name, df.run_uuid, df.lineage_event_time, df.facet
FROM selected_dataset_versions dv
LEFT JOIN dataset_facets_view df ON df.dataset_version_uuid = dv.uuid AND (df.type ILIKE 'dataset' OR df.type ILIKE 'unknown' OR df.type ILIKE 'input')
LEFT JOIN dataset_facets_view df ON df.dataset_version_uuid = dv.uuid AND (df.type ILIKE 'dataset' OR df.type ILIKE 'unknown' OR df.type ILIKE 'input' OR df.type ILIKE 'output')
)
SELECT d.type, d.name, d.physical_name, d.namespace_name, d.source_name, d.description, dv.lifecycle_state,\s
dv.created_at, dv.uuid AS current_version_uuid, dv.version, dv.dataset_schema_version_uuid, dv.fields, dv.run_uuid AS createdByRunUuid,
Expand Down Expand Up @@ -273,7 +273,7 @@ LEFT JOIN (
facet as facets,lineage_event_time
FROM dataset_facets_view
WHERE
(type ILIKE 'dataset' OR type ILIKE 'unknown' OR type ILIKE 'input')
(type ILIKE 'dataset' OR type ILIKE 'unknown' OR type ILIKE 'input' OR type ILIKE 'output')
) f ON f.dataset_version_uuid = dv.uuid
WHERE dv.namespace_name = :namespaceName
AND dv.dataset_name = :datasetName
Expand Down