Skip to content

MAT-9814: pass profile user to ShareDialog unshare - #55

Merged
etan-sb merged 1 commit into
developfrom
feature/MAT-9814/fix-shared-measure-unshare-functionality
Aug 5, 2026
Merged

MAT-9814: pass profile user to ShareDialog unshare#55
etan-sb merged 1 commit into
developfrom
feature/MAT-9814/fix-shared-measure-unshare-functionality

Conversation

@etan-sb

@etan-sb etan-sb commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

MADiE PR

Jira Ticket: MAT-9814
(Optional) Related Tickets:
MeasureAuthoringTool/madie-util#223

Summary

On the Admin Shared Measures tab, when performing an Unshare action, fixed issue where the confirmation modal listed the logged-in admin instead of the profile user the measure is shared with.

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@etan-sb
etan-sb requested a review from a team as a code owner August 4, 2026 20:17
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · -2 duplication

Metric Results
Complexity 0
Duplication -2

View in Codacy

🟢 Coverage ∅ diff coverage · +0.00% coverage variation

Metric Results
Coverage variation +0.00% coverage variation (-1.00%)
Diff coverage diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0abc2c4) 793 780 98.36%
Head commit (1a5fc1d) 793 (+0) 780 (+0) 98.36% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#55) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.42%. Comparing base (0abc2c4) to head (1a5fc1d).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #55   +/-   ##
========================================
  Coverage    91.42%   91.42%           
========================================
  Files           14       14           
  Lines          886      886           
  Branches       220      220           
========================================
  Hits           810      810           
  Misses          15       15           
  Partials        61       61           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@etan-sb
etan-sb merged commit 640eb36 into develop Aug 5, 2026
13 checks passed
@etan-sb
etan-sb deleted the feature/MAT-9814/fix-shared-measure-unshare-functionality branch August 5, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants