Skip to content

MAT-9814: fix Shared Measures unshare targeting wrong user - #223

Merged
etan-sb merged 2 commits into
developfrom
feature/MAT-9814/fix-shared-measure-unshare-functionality
Aug 5, 2026
Merged

MAT-9814: fix Shared Measures unshare targeting wrong user#223
etan-sb merged 2 commits into
developfrom
feature/MAT-9814/fix-shared-measure-unshare-functionality

Conversation

@etan-sb

@etan-sb etan-sb commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

MADiE PR

Jira Ticket: MAT-9814
(Optional) Related Tickets:
MeasureAuthoringTool/madie-admin#55

Summary

On the Admin Shared Measures tab, when performing an Unshare action, fixed issue where the confirmation modal listed the logged-in admin instead of the profile user the measure is shared with.

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@etan-sb
etan-sb requested a review from a team as a code owner August 4, 2026 20:15
@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.27%. Comparing base (c77d925) to head (d5200d1).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #223      +/-   ##
===========================================
- Coverage    95.33%   95.27%   -0.06%     
===========================================
  Files           59       59              
  Lines         1650     1651       +1     
  Branches       309      310       +1     
===========================================
  Hits          1573     1573              
  Misses          23       23              
- Partials        54       55       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@etan-sb
etan-sb merged commit 8dd770c into develop Aug 5, 2026
14 of 15 checks passed
@etan-sb
etan-sb deleted the feature/MAT-9814/fix-shared-measure-unshare-functionality branch August 5, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants