Skip to content

EmbARC: fix download URLs for Mac and Linux - #616

Merged
JeromeMartinez merged 1 commit into
MediaArea:masterfrom
GuillaumeRoques:fix-embarc-download-urls
Apr 9, 2026
Merged

EmbARC: fix download URLs for Mac and Linux#616
JeromeMartinez merged 1 commit into
MediaArea:masterfrom
GuillaumeRoques:fix-embarc-download-urls

Conversation

@GuillaumeRoques

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Guillaume Roques <guillaume.roques@gmail.com>
Copilot AI review requested due to automatic review settings April 9, 2026 10:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates embARC download page templates to correct snapshot download URLs for macOS and Linux artifacts.

Changes:

  • Update macOS GUI/CLI download links to the 20260404 snapshot paths and version labels.
  • Fix Linux GUI link to point to the Linux x64 ZIP artifact (instead of a macOS DMG), and update Linux GUI/CLI snapshot directory to 20260130_sign-4.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/EmbARCBundle/Resources/views/Download/macTable.html.twig Updates macOS GUI/CLI snapshot URLs and displayed version to match the new snapshot.
src/EmbARCBundle/Resources/views/Download/linuxTable.html.twig Corrects Linux GUI/CLI URLs to Linux x64 ZIP artifacts and updates snapshot directory naming.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -2,11 +2,11 @@
<th rowspan="2">Any Linux</th>
<th rowspan="2">Any CPU</th>

Copilot AI Apr 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Linux download row is labeled "Any CPU", but the linked artifacts are explicitly "Linux_x64". This is misleading for users on non-x86_64 architectures; either adjust the label to x86_64/amd64 or provide additional architecture rows/links.

Suggested change
<th rowspan="2">Any CPU</th>
<th rowspan="2">x86_64 / amd64</th>

Copilot uses AI. Check for mistakes.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot good catch but the fix is the opposite (change of the linked artifacts name in order to remove the arch), I merge as is + @g-maxime please remove the arch name in the linked artifacts).

@JeromeMartinez
JeromeMartinez merged commit 429034e into MediaArea:master Apr 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants