Skip to content

EmbARC: fix download URLs for Mac and Linux #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JeromeMartinez merged 1 commit into from
Apr 9, 2026
Merged

EmbARC: fix download URLs for Mac and Linux #616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/EmbARCBundle/Resources/views/Download/linuxTable.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
<th rowspan="2">Any Linux</th>
<th rowspan="2">Any CPU</th>

Copilot AI Apr 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Linux download row is labeled "Any CPU", but the linked artifacts are explicitly "Linux_x64". This is misleading for users on non-x86_64 architectures; either adjust the label to x86_64/amd64 or provide additional architecture rows/links.

Suggested change
<th rowspan="2">Any CPU</th>
<th rowspan="2">x86_64 / amd64</th>

Copilot uses AI. Check for mistakes.

@JeromeMartinez JeromeMartinez Apr 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot good catch but the fix is the opposite (change of the linked artifacts name in order to remove the arch), I merge as is + @g-maxime please remove the arch name in the linked artifacts).

<th><abbr title="Graphical User Interface">GUI</abbr></th>
<td><a href="//mediaarea.net/download/snapshots/branches/binary/embarc-gui/20260130_null/embARC_GUI_1.4.20260130_Mac.dmg">v1.4.20260130</a></td>
<td><a href="//mediaarea.net/download/snapshots/branches/binary/embarc-gui/20260130_sign-4/embARC_GUI_1.4.20260130_Linux_x64.zip">v1.4.20260130</a></td>
<td>A Java Virtual Machine is required</td>
</tr>
<tr>
<th><abbr title="Command Line Interface">CLI</abbr></th>
<td><a href="//mediaarea.net/download/snapshots/branches/binary/embarc/20260130_null/embARC_CLI_1.4.20260130_Linux_x64.zip">v1.4.20260130</a></td>
<td><a href="//mediaarea.net/download/snapshots/branches/binary/embarc/20260130_sign-4/embARC_CLI_1.4.20260130_Linux_x64.zip">v1.4.20260130</a></td>
<td>A Java Virtual Machine is required</td>
</tr>
4 changes: 2 additions & 2 deletions src/EmbARCBundle/Resources/views/Download/macTable.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
<th rowspan="2">macOS 10.12 or later</th>
<th rowspan="2">Universal installer</th>
<th><abbr title="Graphical User Interface">GUI</abbr></th>
<td><a href="//mediaarea.net/download/snapshots/branches/binary/embarc-gui/20260130_null/embARC_GUI_1.4.20260130_Mac.dmg">v1.4.20251129</a></td>
<td><a href="//mediaarea.net/download/snapshots/binary/embarc-gui/20260404/embARC_GUI_1.4.20260404_Mac.dmg">v1.4.20260404</a></td>
<td>If you don't know which one to download, download this one</td>
</tr>
<tr>
<th><abbr title="Command Line Interface">CLI</abbr></th>
<td><a href="//mediaarea.net/download/snapshots/branches/binary/embarc/20260130_null/embARC_CLI_1.4.20260130_Mac.dmg">v1.4.20260130</a></td>
<td><a href="//mediaarea.net/download/snapshots/binary/embarc/20260404/embARC_CLI_1.4.20260404_Mac.dmg">v1.4.20260404</a></td>
<td>&nbsp;</td>
</tr>
Loading