Skip to content

add check for done state #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jenny Hickson (jennyhickson) merged 2 commits into from
Feb 11, 2026
Merged

add check for done state #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a17210
add check for done state
james-bruten-mo Feb 10, 2026
7c09ffe
correct logic
james-bruten-mo Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/track-review-project.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,16 @@ jobs:
echo "SCITECH_REVIEWER=$scitech_reviewer" >> $GITHUB_ENV
echo "CODE_REVIEWER=$code_reviewer" >> $GITHUB_ENV

# If the PR isn't OPEN then required project state is "Done"
# This marks the PR as Done whether it has been merged or not
# Draft PRs have an OPEN state
state=$(echo "$pr_data" | jq -r '.state')
if [[ "$state" != "OPEN" ]]; then
required_state="Done"
echo "REQUIRED_STATE=$required_state" >> $GITHUB_ENV
exit 0
fi

# Determine review state
reviews=$(echo "$pr_data" | jq -c '{reviews, reviewRequests}')
sr_requested=$(echo "$reviews" | jq --arg sr "$scitech_reviewer" '[.reviewRequests[] | select(.login == $sr)] | length')
Expand Down
2 changes: 1 addition & 1 deletion track-review-project/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ name: Trigger Review Project

on:
pull_request_target:
types: ["opened", "synchronize", "reopened", "edited", "review_requested", "review_request_removed"]
types: ["opened", "synchronize", "reopened", "edited", "review_requested", "review_request_removed", "closed"]
pull_request_review:
pull_request_review_comment:

Expand Down
Loading