Add tag to avoid vernier CCE MPI bug - #261
Conversation
| name = 'Vernier' | ||
| if ( LPROF ) then | ||
| call vernier_init( communicator%get_comm_mpi_val() ) | ||
| call vernier_init( communicator%get_comm_mpi_val(), tag='lfric' ) |
There was a problem hiding this comment.
Would it make more sense to pass the application_name through as the tag to vernier?
There was a problem hiding this comment.
It could do, though this was just to get the workaround on trunk quick as opposed to a perfect solution.
Ideally we wouldn't worry at all about the tags.
There was a problem hiding this comment.
I think changing 'lfric' to trim(application_name) would make sense for this fix, just in case we get stuck using a hard-coded name for the long term if we never get around to reverting it
There was a problem hiding this comment.
Given its right there in the timing_mod anyway, I don't mind adding it.
Andrew Coughtrie (@andrewcoughtrie), does this work as an alternative to 'lfric' ?
There was a problem hiding this comment.
Running the tests now
There was a problem hiding this comment.
Happy with the way this is implemented - passing on to CR Andrew Coughtrie (@andrewcoughtrie)
Andrew Coughtrie (andrewcoughtrie)
left a comment
There was a problem hiding this comment.
This all looks good to me.
Andrew Coughtrie (andrewcoughtrie)
left a comment
There was a problem hiding this comment.
All is good and the tests pass.
ba96576
into
MetOffice:main
Officiate the workaround so that Vernier can work out of the box at HoT without manual adjustments by users.
PR Summary
Sci/Tech Reviewer: Ed Hone (@EdHone)
Code Reviewer: Andrew Coughtrie (@andrewcoughtrie)
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_core - add_vernier_tag/run5
Suite Information
Task Information
✅ succeeded tasks - 370
Test Suite Results - lfric_apps - hot_testing/run6
Suite Information
Task Information
❌ failed tasks - 3
Outputs produced:

Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review