Skip to content

Add tag to avoid vernier CCE MPI bug #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Andrew Coughtrie (andrewcoughtrie) merged 7 commits into from
Feb 2, 2026
Merged

Add tag to avoid vernier CCE MPI bug #261

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
11bee4c
Add tag to avoid vernier CCE MPI bug
MetBenjaminWent Jan 30, 2026
4639446
Add contributor
MetBenjaminWent Jan 30, 2026
2b1e9cc
Merge branch 'main' into add_vernier_tag
MetBenjaminWent Jan 30, 2026
834425f
SR suggestion to use application name
MetBenjaminWent Feb 2, 2026
0d9edc0
Merge branch 'add_vernier_tag' of github.com:MetBenjaminWent/lfric_co…
MetBenjaminWent Feb 2, 2026
e0ad4c3
fix formatting
MetBenjaminWent Feb 2, 2026
de20726
Merge branch 'main' into add_vernier_tag
andrewcoughtrie Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@
| harry-shepherd | Harry Shepherd | Met Office | 2026-01-08 |
| EdHone | Ed Hone | Met Office | 2026-01-09 |
| tom-j-h | Tom Hill | Met Office | 2026-01-19 |
| MetBenjaminWent | Benjamin Went | Met Office | 2026-01-30 |
2 changes: 1 addition & 1 deletion infrastructure/source/utilities/timing_mod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ subroutine init_timing( communicator, lsubroutine_timers, application_name, &
#elif defined( VERNIER )
name = 'Vernier'
if ( LPROF ) then
call vernier_init( communicator%get_comm_mpi_val() )
call vernier_init( communicator%get_comm_mpi_val(), tag='lfric' )

@EdHone Ed Hone (EdHone) Jan 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make more sense to pass the application_name through as the tag to vernier?

@MetBenjaminWent Benjamin Went (MetBenjaminWent) Jan 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could do, though this was just to get the workaround on trunk quick as opposed to a perfect solution.

Ideally we wouldn't worry at all about the tags.

@EdHone Ed Hone (EdHone) Jan 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think changing 'lfric' to trim(application_name) would make sense for this fix, just in case we get stuck using a hard-coded name for the long term if we never get around to reverting it

@MetBenjaminWent Benjamin Went (MetBenjaminWent) Jan 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given its right there in the timing_mod anyway, I don't mind adding it.

Andrew Coughtrie (@andrewcoughtrie), does this work as an alternative to 'lfric' ?

@MetBenjaminWent Benjamin Went (MetBenjaminWent) Jan 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running the tests now

if ( LPROF ) call vernier_start( global_timing_handle, '__' // &
application_name // '__' )

Expand Down
Loading