revert: Revert moving connect-multichain into peerDep for ecosystem packages#323
Open
jiexi wants to merge 3 commits into
Open
revert: Revert moving connect-multichain into peerDep for ecosystem packages#323jiexi wants to merge 3 commits into
jiexi wants to merge 3 commits into
Conversation
adonesky1
reviewed
Jun 10, 2026
|
|
||
| ### Changed | ||
|
|
||
| - `@metamask/connect-multichain` is no longer a peer dependency and will be installed transitively as a regular dependency ([#323](https://github.com/MetaMask/connect-monorepo/pull/323)) |
Contributor
There was a problem hiding this comment.
Trying to reason about whether this is breaking again or not 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Reverts just the peerDep changes from 7786de8 . The devex degradation for library consumers having to install two peerDeps (ecosystem client, and multichain client) isn't worth the gains from build time warnings.
References
Fixes: https://consensys.slack.com/archives/C058P09HT17/p1781040721508819?thread_ts=1781037006.244619&cid=C058P09HT17
Checklist