Skip to content

revert: Revert moving connect-multichain into peerDep for ecosystem packages #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jiexi wants to merge 3 commits into
base: main
Choose a base branch
from
Open

revert: Revert moving connect-multichain into peerDep for ecosystem packages #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3de276
Revert peerDep change
jiexi Jun 10, 2026
ac70c34
Merge branch 'main' into jl/revert-buildtime-versioning
jiexi Jun 10, 2026
a76ff37
changelog
jiexi Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/connect-evm/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- `@metamask/connect-multichain` is no longer a peer dependency and will be installed transitively as a regular dependency ([#323](https://github.com/MetaMask/connect-monorepo/pull/323))

@adonesky1 adonesky1 Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to reason about whether this is breaking again or not 🤔

@adonesky1 adonesky1 Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not.


### Fixed

- `EIP1193Provider.request()` now preserves JSON-RPC error `data` on provider-facing errors when `connect-multichain` surfaces a wallet error through `RPCInvokeMethodErr`. Dapps can read revert reasons, custom-error bytes, and other wallet-provided error metadata from `error.data` alongside the original wallet `error.code` and `error.message`. ([#312](https://github.com/MetaMask/connect-monorepo/pull/312))
Expand Down
5 changes: 1 addition & 4 deletions packages/connect-evm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,12 @@
},
"dependencies": {
"@metamask/analytics": "workspace:^",
"@metamask/connect-multichain": "workspace:^",
"@metamask/utils": "^11.8.1",
"semver": "^7.7.4"
},
"devDependencies": {
"@metamask/auto-changelog": "^3.4.4",
"@metamask/connect-multichain": "workspace:^",
"@types/jsdom": "^21.1.7",
"@types/semver": "^7.7.1",
"@vitest/coverage-v8": "^3.2.4",
Expand All @@ -72,9 +72,6 @@
"typescript": "^5.9.3",
"vitest": "^3.1.2"
},
"peerDependencies": {
"@metamask/connect-multichain": "workspace:^"
},
"engines": {
"node": ">=20.19.0"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/connect-evm/tsup.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const external = [...deps, ...peerDeps];
const entryName = pkg.name.replace('@metamask/', '');

const multichainPeerRange = resolveWorkspaceRange(
pkg.peerDependencies?.['@metamask/connect-multichain'],
pkg.dependencies?.['@metamask/connect-multichain'],
multichainPkg.version,
);

Expand Down
4 changes: 4 additions & 0 deletions packages/connect-solana/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- `@metamask/connect-multichain` is no longer a peer dependency and will be installed transitively as a regular dependency ([#323](https://github.com/MetaMask/connect-monorepo/pull/323))

## [2.0.0]

### Added
Expand Down
5 changes: 1 addition & 4 deletions packages/connect-solana/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,14 @@
"test:watch": "vitest watch"
},
"dependencies": {
"@metamask/connect-multichain": "workspace:^",
"@metamask/solana-wallet-standard": "^0.6.0",
"@wallet-standard/app": "~1.1.0",
"@wallet-standard/base": "^1.1.0",
"semver": "^7.7.4"
},
"devDependencies": {
"@metamask/auto-changelog": "^3.4.4",
"@metamask/connect-multichain": "workspace:^",
"@types/jsdom": "^21.1.7",
"@types/semver": "^7.7.1",
"@vitest/coverage-v8": "^3.2.4",
Expand All @@ -77,9 +77,6 @@
"typescript": "^5.9.3",
"vitest": "^3.1.2"
},
"peerDependencies": {
"@metamask/connect-multichain": "workspace:^"
},
"engines": {
"node": ">=20.19.0"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/connect-solana/tsup.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const external = [...deps, ...peerDeps];
const entryName = pkg.name.replace('@metamask/', '');

const multichainPeerRange = resolveWorkspaceRange(
pkg.peerDependencies?.['@metamask/connect-multichain'],
pkg.dependencies?.['@metamask/connect-multichain'],
multichainPkg.version,
);

Expand Down
19 changes: 0 additions & 19 deletions yarn.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,15 +641,6 @@ function expectUpToDateWorkspacePeerDependencies(Yarn, workspace) {
dependencyWorkspace !== null &&
dependency.type === 'peerDependencies'
) {
// Yarn rewrites `workspace:` protocol ranges to a satisfying semver
// range at publish time (e.g. `workspace:^` -> `^<workspace-version>`),
// so by construction they always satisfy the workspace version. Skip
// the satisfies() check, which would otherwise treat `workspace:^` as
// an invalid range and "fix" it to `^<major>.0.0`.
if (dependency.range.startsWith('workspace:')) {
continue;
}

const dependencyWorkspaceVersion = new semver.SemVer(
dependencyWorkspace.manifest.version,
);
Expand Down Expand Up @@ -732,16 +723,6 @@ function expectPeerDependenciesAlsoListedAsDevDependencies(
const dependencyWorkspace = Yarn.workspace({ ident: dependencyIdent });

if (dependencyWorkspace) {
const existingDevDependency =
dependencyInstancesByType.get('devDependencies');
const ignoredRanges = ALLOWED_INCONSISTENT_DEPENDENCIES[dependencyIdent];
if (
existingDevDependency &&
ignoredRanges?.includes(existingDevDependency.range)
) {
continue;
}

expectWorkspaceField(
workspace,
`devDependencies["${dependencyIdent}"]`,
Expand Down
4 changes: 0 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4011,8 +4011,6 @@ __metadata:
typedoc-plugin-missing-exports: "npm:^4.1.2"
typescript: "npm:^5.9.3"
vitest: "npm:^3.1.2"
peerDependencies:
"@metamask/connect-multichain": "workspace:^"
languageName: unknown
linkType: soft

Expand Down Expand Up @@ -4136,8 +4134,6 @@ __metadata:
typedoc-plugin-missing-exports: "npm:^4.1.2"
typescript: "npm:^5.9.3"
vitest: "npm:^3.1.2"
peerDependencies:
"@metamask/connect-multichain": "workspace:^"
languageName: unknown
linkType: soft

Expand Down
Loading