refactor: remove ScreenComponent any cast from Perps routes

[asalsys]

Description

Simplify the PerpsConfirmScreen wrapper to rely solely on useRoute() hook (which it was already using), removing the redundant route prop type and the type ScreenComponent = React.ComponentType<any> escape hatch.

Part of the React Navigation v6 migration effort to remove no-explicit-any violations from route files.

Changes:

• routes/index.tsx: Remove route from PerpsConfirmScreen props, rely on useRoute() only. Remove ScreenComponent type alias and as ScreenComponent cast.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

N/A — pure refactoring with no user-facing behavior change.

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor

---

Note

Low Risk
Low risk refactor limited to React Navigation wiring and TypeScript types; behavior should remain the same aside from how showPerpsHeader is read from route params.

Overview
Simplifies PerpsConfirmScreen to no longer accept/forward navigation props and instead read showPerpsHeader directly from useRoute() params when rendering Confirm.

Removes the ScreenComponent = React.ComponentType<any> escape hatch and the as ScreenComponent cast in the stack screen registration, improving typing as part of the React Navigation v6 migration.

^{Written by Cursor Bugbot for commit 6de9b09. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[asalsys]

Closing: rebasing onto main since the navigation v6 branch was merged.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokePerps, SmokeWalletPlatform, SmokeConfirmations
• Selected Performance tags: None (no tests recommended)
• Risk Level: medium
• AI Confidence: 90%

click to see 🤖 AI reasoning details

E2E Test Selection:
The change is a focused refactoring/bug fix in app/components/UI/Perps/routes/index.tsx:

1. Bug fix: params?.params?.showPerpsHeader → params?.showPerpsHeader — the double .params nesting was incorrect and likely caused showPerpsHeader to always be undefined, meaning the Perps confirmation header was never shown correctly.

2. Simplification: PerpsConfirmScreen now uses useRoute() directly instead of accepting forwarded props, and the TypeScript cast workaround was removed.

3. Scope: Entirely within the Perps feature's navigation/routing layer, specifically affecting the confirmation screen header display.

Tags selected:

• SmokePerps: Directly tests the Perps feature including Add Funds flow and balance verification — the confirmation screen is part of this flow.
• SmokeWalletPlatform: Per tag description, Perps is a section inside the Trending tab; changes to Perps views affect Trending.
• SmokeConfirmations: Per SmokePerps tag description, "Add Funds deposits are on-chain transactions" requiring confirmations — and the changed component is literally the Perps confirmation screen wrapper.

No performance impact expected from this change (it's a routing/component simplification with no rendering overhead changes).

Performance Test Selection:
The change is a minor refactoring of the PerpsConfirmScreen component — removing a type alias, fixing a params nesting bug, and simplifying prop handling. There are no changes to rendering logic, list components, data fetching, or state management that would impact performance metrics. No performance tests are warranted.

View GitHub Actions results

[github-actions]

✅ E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
20.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud