Skip to content

refactor: remove ScreenComponent any cast from Perps routes #28116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asalsys merged 5 commits into from
Mar 31, 2026
+5 −12
Merged

refactor: remove ScreenComponent any cast from Perps routes #28116

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7d24b49
refactor: remove ScreenComponent any cast from Perps routes
asalsys Mar 31, 2026
508e8cc
Merge branch 'main' into refactor/remove-screen-component-any-perps
asalsys Mar 31, 2026
bde3e38
Merge branch 'main' into refactor/remove-screen-component-any-perps
asalsys Mar 31, 2026
e6683c6
Merge branch 'main' into refactor/remove-screen-component-any-perps
asalsys Mar 31, 2026
6de9b09
remove screenComponent
asalsys Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions app/components/UI/Perps/routes/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,6 @@ import { CONFIRMATION_HEADER_CONFIG } from '../constants/perpsConfig';
const Stack = createStackNavigator<PerpsNavigationParamList>();
const ModalStack = createStackNavigator();

// eslint-disable-next-line @typescript-eslint/no-explicit-any
type ScreenComponent = React.ComponentType<any>;

const styles = StyleSheet.create({
container: {
flex: 1,
Expand All @@ -65,18 +62,14 @@ function getRedesignedConfirmationsHeaderOptions({
: { header: () => null };
}

const PerpsConfirmScreen = (
props: React.ComponentProps<typeof Confirm> & {
route: RouteProp<PerpsNavigationParamList, 'RedesignedConfirmations'>;
},
) => {
const params =
const PerpsConfirmScreen = () => {
const { params } =
useRoute<RouteProp<PerpsNavigationParamList, 'RedesignedConfirmations'>>();
const showPerpsHeader =
params?.params?.showPerpsHeader ??
params?.showPerpsHeader ??
CONFIRMATION_HEADER_CONFIG.DefaultShowPerpsHeader;

return <Confirm {...props} disableSafeArea={!showPerpsHeader} />;
return <Confirm disableSafeArea={!showPerpsHeader} />;
};

const PerpsModalStack = () => {
Expand Down Expand Up @@ -421,7 +414,7 @@ const PerpsScreenStack = () => {

<Stack.Screen
name={Routes.FULL_SCREEN_CONFIRMATIONS.REDESIGNED_CONFIRMATIONS}
component={PerpsConfirmScreen as ScreenComponent}
component={PerpsConfirmScreen}
options={({ route }) =>
getRedesignedConfirmationsHeaderOptions(route.params)
}
Expand Down
Loading