Add uniform random scale to ParticleVector2Parameter#1130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
Uniformflag toParticleVector2Parameterthat, when set withKind = Random, samples a single float and applies it to both X and Y axes. This guarantees per particle aspect ratio preservation when using random scale on a particle emitter. Without this flag, X and Y are sampled independently, meaning each particle can receive a non square scale even when the min/max range is symmetric.Related Issues/Tickets
Changes Made
ParticleVector2Parameter: addedpublic bool Uniformfield (defaultfalse); updated theValuegetter to sample a single value from the X range and returnVector2(s, s)whenUniformis true andKindisRandom.ParticleEffectSerializer: reads theUniformXML attribute with a default offalse; writes it only whentrue, preserving backward compatibility with existing.emberfiles.ParticleEffectReader/ParticleEffectWriter: same read/write changes for the content pipeline (.xnb) variants.Checklist