Cancelling changing the texture in Ember removes path and ember crashes if texture cannot be found when loaded#1132
Merged
AristurtleDev merged 1 commit intoApr 10, 2026
Conversation
When deserializing a .ember file, texture.Name was set to Path.GetFileName(path) which stripped the relative directory. On re-save, the full relative path was lost, causing the texture to not be found when reopening the file. Preserve the original relative path from the .ember file instead.
ericlothspeich
marked this pull request as ready for review
March 30, 2026 06:13
Collaborator
|
Thanks @ericlothspeich i'll have to review this a little later this afternoon |
AristurtleDev
added
bug
Contributor
Author
Yup! Thanks for all the work! |
AristurtleDev
approved these changes
Apr 10, 2026
Collaborator
|
Sorry again for the delay. I wanted to check if there was anywhere else, maybe on the ember side, that something should be checked as well, but this looks like the best fix for it |
Contributor
Author
|
Glad I could help! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Choosing the texture slot in Ember when a texture is already loaded wipes the path. If the user chooses cancel, the texture only shows name and extension. If the ember project is saved, the path is removed from the ember file. Opening the file later, crashes the program
Related Issues/Tickets
closes #1131
Changes Made
One-line change in ParticleEffectSerializer.ReadTexture2DRegion: use name (the original relative path read from the XML attribute) instead of Path.GetFileName(path) when setting texture.Name.
Checklist
Please read and check the following items. Pull requests will not be reviewed if all items are not checked.