Feature/games tests and pagination - #1320
Merged
aji70 merged 7 commits intoJun 28, 2026
Merged
Conversation
Cover joinGame happy path and edge cases: successful join, sequential and random turn order, custom starting cash, and error states (not found, not pending, full game, duplicate player).
Test JoinGameDto validation: valid UUID, missing userId, empty string, non-UUID string, numeric value, null, truncated UUID, and v4 UUID.
E2E tests for POST /v1/games/:id/join (404, invalid body, valid shape) and GET /v1/games with pagination (limit, page, status filter, defaults, boundary validation).
Add GET /v1/games endpoint with page/limit/status query params. ListGamesDto extends PaginationDto for consistent validation. Service uses queryBuilder with skip/take and returns PaginatedResponseDto.
|
@jhayniffy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1031
closes #1032
closes #1033
closes #1034
Implement the change in the relevant code paths
Wire or persist state where the feature touches runtime behavior
Add tests (unit, integration, and/or contract/UI as appropriate)
Implement the change in the relevant code paths
Wire or persist state where the feature touches runtime behavior
Add tests (unit, integration, and/or contract/UI as appropriate)