Fix AOSS delete-by-query pagination and progress logging - #303
Merged
Conversation
AOSS eventual consistency means deleted docs can still appear in the next search immediately after deletion, so a single-pass search-then- delete only removes one page and reports success. Loop until the search returns an empty page to guarantee full deletion. Also adds INFO-level progress logging (one line per batch) and drops redundant page-number messages to DEBUG. Fixes #302 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Merged
2 tasks
|
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RestClientWrapper._performDBQRequest(): loop until the search page is empty rather than doing a single pass. AOSS eventual consistency means deleted docs remain visible to subsequent searches, so a single-pass search-then-delete silently leaves documents behind on every call.Test plan
registry-manager delete-dd -ns <namespace>against an AOSS node with multiple pages of docs for that namespace and confirm all are deleted (count reaches 0 and stays there)Fixes #302
🤖 Generated with Claude Code