docs(nooa_memory): fixed broken tests/memory/ link in README - #64
Merged
alessiodevoto merged 1 commit intoJul 31, 2026
Merged
Conversation
…nk had one extra ../, resolving to a nonexistent top-level tests/memory/ instead of packages/nooa-memory/tests/memory/
Collaborator
|
Hi @shivaperumalsamy thanks for catching this! |
Hotragn
added a commit
to Hotragn/labs-OO-Agents
that referenced
this pull request
Aug 6, 2026
This README sits at packages/nooa-memory/src/nooa_memory/, so reaching the repo
root takes four levels, not three. `../../../examples/quickstart/12_memory.py`
resolves to `packages/examples/quickstart/12_memory.py`, which does not exist, so
the link 404s on GitHub.
Verified from the file's own directory:
../../../examples/quickstart/12_memory.py -> packages/examples/... missing
../../../../examples/quickstart/12_memory.py -> examples/... exists
Same class as NVIDIA-NeMo#64, which fixed the tests/memory/ link in this file.
The remaining `examples/memory_bench/` references in this README are a separate
problem: that directory is absent at every depth, so no path adjustment fixes
them. Reported separately rather than guessed at here.
Signed-off-by: hotragn <hotragn.pettugani_2024@woxsen.edu.in>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/nooa-memory/src/nooa_memory/README.mdlinked totests/memory/with one extra
../, so the link resolved to a nonexistent top-leveltests/memory/instead of the actualpackages/nooa-memory/tests/memory/.What does this PR do?
Fixes the relative path so the link resolves correctly from the file's
location (
packages/nooa-memory/src/nooa_memory/).What changed
packages/nooa-memory/src/nooa_memory/README.md:../../../tests/memory/→../../tests/memory/Related issues
None — found by reading through the README and checking that its links resolve.