Skip to content

[JOSS] Editorial suggestions#329

Merged
RDaxini merged 2 commits into
NatLabRockies:JOSS-PAperfrom
AdamRJensen:patch-1
Jun 30, 2026
Merged

[JOSS] Editorial suggestions#329
RDaxini merged 2 commits into
NatLabRockies:JOSS-PAperfrom
AdamRJensen:patch-1

Conversation

@AdamRJensen

@AdamRJensen AdamRJensen commented May 28, 2026

Copy link
Copy Markdown

Editorilal suggetions for the JOSS paper. See openjournals/joss-reviews#9808.

@AdamRJensen AdamRJensen changed the title JOSS editorial suggestions [JOSS] Editorial suggestions May 28, 2026
RDaxini
RDaxini reviewed Jun 26, 2026
View reviewed changes

@RDaxini RDaxini left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdamRJensen Thank you for carefully reviewing the manuscript and offering your suggestions. Before implementing any changes, I would first like to double check something. What is the motivation for removing the comments regarding the tutorial notebooks? These notebooks are a core part of PVDeg's functionality, accessibility, and indirect testing infrastructure. For example, the changes on lines 55 and 64. Besides this point regarding the notebooks, I agree with and will implement all other changes that you have recommended.

@RDaxini RDaxini added the JOSS label Jun 26, 2026
@RDaxini RDaxini added this to the v0.7.2 milestone Jun 26, 2026
@AdamRJensen

AdamRJensen commented Jun 30, 2026

Copy link
Copy Markdown
Author

@AdamRJensen Thank you for carefully reviewing the manuscript and offering your suggestions. Before implementing any changes, I would first like to double check something. What is the motivation for removing the comments regarding the tutorial notebooks? These notebooks are a core part of PVDeg's functionality, accessibility, and indirect testing infrastructure. For example, the changes on lines 55 and 64. Besides this point regarding the notebooks, I agree with and will implement all other changes that you have recommended.

Your paper seemed much longer than the typical JOSS paper, so this was my attempt at shortening it. The official guidelines are:

The paper should be between 750-1750 words

RDaxini
RDaxini approved these changes Jun 30, 2026
View reviewed changes

@RDaxini RDaxini left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestions.

The nbval failure is unrelated to the changes in this PR.

@RDaxini RDaxini merged commit bb3b602 into NatLabRockies:JOSS-PAper Jun 30, 2026
16 of 17 checks passed
@RDaxini RDaxini mentioned this pull request Jun 30, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RDaxini RDaxini RDaxini approved these changes

Assignees

No one assigned

Labels

JOSS

Projects

None yet

Milestone

v0.7.2

Development

Successfully merging this pull request may close these issues.

2 participants

@AdamRJensen @RDaxini