Conversation
rajeee
commented
Aug 15, 2025
| with zipfile.ZipFile(weather_file_path, "r") as zf: | ||
| logger.debug("Extracting weather files to: {}".format(self.weather_dir)) | ||
| zf.extractall(self.weather_dir) | ||
| if os.path.isdir(weather_file_path): |
Collaborator
Author
There was a problem hiding this comment.
weather file path now can be directory too (not just a zipfile). Will make buildstock_local much faster if using pre-unzipped directory.
asparke2
approved these changes
Aug 15, 2025
| with zipfile.ZipFile(weather_file_path, "r") as zf: | ||
| logger.debug("Extracting weather files to: {}".format(self.weather_dir)) | ||
| zf.extractall(self.weather_dir) | ||
| if os.path.isdir(weather_file_path): |
| repository: NREL/resstock | ||
| path: resstock | ||
| ref: develop | ||
| ref: better-minimal-buildstock |
Member
There was a problem hiding this comment.
Assume this gets changed back after resstock gets updated too.
Collaborator
Author
There was a problem hiding this comment.
Yeah, this PR relies on some changes on resstock currently only available on that branch. These two branches are mutually tied up together - one needs the other. So, once we are ready on both sides, we switch the branch to develop on both sides and merge both side in quick order.
asparke2
approved these changes
Aug 15, 2025
|
|
||
| def get_data_dict_schema(stock_type, all_cols): | ||
| if stock_type == "residential": | ||
| from resstockpostproc import get_polars_schema_from_data_dictionary |
Member
There was a problem hiding this comment.
Will add ComStock version of this function in comstockpostprocessing.
Minimum allowed line rate is |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Pull Request Description
Simplifies the postprocessing by writing partitioned annual parquet files. This reduces the memory consumption during postprocessing because it is no longer necessary to read all the results_jobxx.json files to get the result for a particular upgrade. They can be simply read by reading all the parquet files in the simulation_ouput/annual/upxx/ folder.
In addition, few other changes (probably should have been a separate PR ...)
Checklist
Not all may apply
minimum_coveragein.github/workflows/coverage.ymlas necessary.