Skip to content

top-level/stage: assert no by-name overwrites#483820

Merged
mdaniels5757 merged 1 commit into
NixOS:masterfrom
qweered:no-by-name-overrides
Mar 20, 2026
Merged

top-level/stage: assert no by-name overwrites#483820
mdaniels5757 merged 1 commit into
NixOS:masterfrom
qweered:no-by-name-overrides

Conversation

@qweered

@qweered qweered commented Jan 26, 2026 •
edited by mdaniels5757
Loading

Copy link
Copy Markdown
Contributor

This asserts that no by-name packages are overwritten by definitions in all-packages.nix.

Resurrection of #454525

Remaining packages with overrides:

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

This was referenced Jan 26, 2026
Draft
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 31, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@qweered

qweered commented Jan 31, 2026

Copy link
Copy Markdown
Contributor Author

Everything ready, we just need to merge those prs

@qweered

qweered commented Feb 1, 2026

Copy link
Copy Markdown
Contributor Author

cc @mdaniels5757 @gepbird, would appreciate your review/merge for prs marked as unchecked

@mdaniels5757

mdaniels5757 commented Feb 1, 2026

Copy link
Copy Markdown
Member

I'm subscribed to all of them, and merged the unmaintained ones or the ones approved by all maintainers. Per maintainers/README.md, I'll wait a week for the others.

@mdaniels5757 mdaniels5757 self-requested a review February 1, 2026 21:02
@gepbird

This comment was marked as resolved.

Sign in to view
@gepbird gepbird mentioned this pull request Feb 2, 2026
Closed
3 tasks
@MattSturgeon

MattSturgeon commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

Per maintainers/README.md, I'll wait a week for the others.

I've gone ahead and merged some of the trivial ones early. Sorry to any maintainers who object; feel free to shout at me or open followup PRs if needed.

@MattSturgeon MattSturgeon mentioned this pull request Feb 4, 2026
Merged
2 tasks
@qweered qweered force-pushed the no-by-name-overrides branch from 19b5914 to ce81ca8 Compare February 10, 2026 02:18
@qweered qweered mentioned this pull request Feb 10, 2026
Draft
98 tasks
@qweered

qweered commented Feb 12, 2026

Copy link
Copy Markdown
Contributor Author

Only #485675 left and we need to wait till #485689 hits master 🔥

@qweered qweered mentioned this pull request Feb 24, 2026
Merged
13 tasks
@qweered qweered force-pushed the no-by-name-overrides branch from ce81ca8 to 47c6688 Compare February 24, 2026 18:43
@mdaniels5757 mdaniels5757 mentioned this pull request Mar 1, 2026
Merged
2 tasks
@qweered qweered mentioned this pull request Mar 2, 2026
Merged
13 tasks
mdaniels5757 added a commit to mdaniels5757/nixpkgs that referenced this pull request Mar 8, 2026
@mdaniels5757
stirling-pdf: remove override in all-packages.nix
251eb33 
This is a step towards NixOS#483820, which will help enable checking for
additional by-name directories (e.g. Python) in nixpkgs-vet.

## Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

- [ ] 0 rebuilds.
- [x] Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and other READMEs.

[NixOS tests]: https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests
[Package tests]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests
[nixpkgs-review usage]: https://github.com/Mic92/nixpkgs-review#usage

[CONTRIBUTING.md]: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md
[lib/tests]: https://github.com/NixOS/nixpkgs/blob/master/lib/tests
[maintainers/README.md]: https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md
[nixos/tests]: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests
[pkgs/README.md]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md
[pkgs/test]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/test
@mdaniels5757 mdaniels5757 mentioned this pull request Mar 8, 2026
Merged
2 tasks
Videl pushed a commit to Videl/nixpkgs that referenced this pull request Mar 9, 2026
@mdaniels5757 @Videl
stirling-pdf: remove override in all-packages.nix
90b1f40 
This is a step towards NixOS#483820, which will help enable checking for
additional by-name directories (e.g. Python) in nixpkgs-vet.

## Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

- [ ] 0 rebuilds.
- [x] Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and other READMEs.

[NixOS tests]: https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests
[Package tests]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests
[nixpkgs-review usage]: https://github.com/Mic92/nixpkgs-review#usage

[CONTRIBUTING.md]: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md
[lib/tests]: https://github.com/NixOS/nixpkgs/blob/master/lib/tests
[maintainers/README.md]: https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md
[nixos/tests]: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests
[pkgs/README.md]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md
[pkgs/test]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/test
stepbrobd pushed a commit to stepbrobd/nixpkgs that referenced this pull request Mar 9, 2026
@mdaniels5757 @stepbrobd
stirling-pdf: remove override in all-packages.nix
bd31ec9 
This is a step towards NixOS#483820, which will help enable checking for
additional by-name directories (e.g. Python) in nixpkgs-vet.

## Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

- [ ] 0 rebuilds.
- [x] Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and other READMEs.

[NixOS tests]: https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests
[Package tests]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests
[nixpkgs-review usage]: https://github.com/Mic92/nixpkgs-review#usage

[CONTRIBUTING.md]: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md
[lib/tests]: https://github.com/NixOS/nixpkgs/blob/master/lib/tests
[maintainers/README.md]: https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md
[nixos/tests]: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests
[pkgs/README.md]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md
[pkgs/test]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/test
@mdaniels5757 mdaniels5757 mentioned this pull request Mar 15, 2026
Merged
2 tasks
@wolfgangwalther @mdaniels5757
top-level/stage: assert no by-name overwrites
e07663a 
This asserts that no by-name packages are overwritten by definitions in
all-packages.nix.
@mdaniels5757 mdaniels5757 force-pushed the no-by-name-overrides branch from 47c6688 to e07663a Compare March 20, 2026 21:04
@mdaniels5757 mdaniels5757 enabled auto-merge March 20, 2026 21:04
@mdaniels5757 mdaniels5757 added this pull request to the merge queue Mar 20, 2026
@nixpkgs-ci nixpkgs-ci Bot requested a review from Ericson2314 March 20, 2026 21:09
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 20, 2026
Merged via the queue into NixOS:master with commit e25f009 Mar 20, 2026
28 checks passed
@qweered

qweered commented Mar 22, 2026

Copy link
Copy Markdown
Contributor Author

🎉

@qweered qweered deleted the no-by-name-overrides branch March 22, 2026 21:37
@w-lfchen w-lfchen mentioned this pull request Apr 14, 2026
Merged
13 tasks
@mdaniels5757 mdaniels5757 mentioned this pull request May 8, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdaniels5757 mdaniels5757 Awaiting requested review from mdaniels5757
@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@qweered @mdaniels5757 @gepbird @MattSturgeon @wolfgangwalther