Skip to content

heptagon: move override to package.nix#493748

Merged
mdaniels5757 merged 1 commit into
NixOS:masterfrom
qweered:heptagon-remove-override
Mar 2, 2026
Merged

heptagon: move override to package.nix#493748
mdaniels5757 merged 1 commit into
NixOS:masterfrom
qweered:heptagon-remove-override

Conversation

@qweered

@qweered qweered commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

Things done

This is the last step for #483820

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@qweered qweered requested a review from gepbird February 24, 2026 18:43
@nixpkgs-ci nixpkgs-ci Bot requested a review from wegank February 24, 2026 18:46
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 24, 2026

@gepbird gepbird left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

(Similar by-name changes involving ocaml resulted in a failure for the static package, in this case pkgsStatic.heptagon, but it was already failing for this package so let's not bother with it. See #490310 for more details.)

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 25, 2026
@qweered qweered requested a review from mdaniels5757 March 2, 2026 13:51
@mdaniels5757 mdaniels5757 added this pull request to the merge queue Mar 2, 2026
Merged via the queue into NixOS:master with commit 1274c74 Mar 2, 2026
34 of 36 checks passed
@qweered qweered deleted the heptagon-remove-override branch April 24, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants