Skip to content

neovim-unwrapped: move overrides to package.nix#485677

Merged
GaetanLepage merged 1 commit into
NixOS:masterfrom
qweered:neovim-unwrapped-move-overrides
Jan 31, 2026
Merged

neovim-unwrapped: move overrides to package.nix#485677
GaetanLepage merged 1 commit into
NixOS:masterfrom
qweered:neovim-unwrapped-move-overrides

Conversation

@qweered

@qweered qweered commented Jan 31, 2026

Copy link
Copy Markdown
Contributor

Split from #474456.

This is a step towards #454525, which will help enable checking for additional by-name directories (e.g. Python) in nixpkgs-vet.

Things done

@qweered qweered force-pushed the neovim-unwrapped-move-overrides branch from c7b0fc6 to af1942b Compare January 31, 2026 17:43
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 31, 2026
@khaneliman

Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 485677
Commit: af1942b10a5f67e2e5aa84705fd7354cbe58e44e

khaneliman

This comment was marked as spam.

@khaneliman khaneliman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 31, 2026
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 31, 2026
@qweered qweered requested a review from mdaniels5757 January 31, 2026 18:08
@GaetanLepage GaetanLepage added this pull request to the merge queue Jan 31, 2026
Merged via the queue into NixOS:master with commit 8d3bf40 Jan 31, 2026
36 of 39 checks passed
@qweered qweered deleted the neovim-unwrapped-move-overrides branch January 31, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants