Skip to content

detect: remove flag SIGMATCH_DEONLY_COMPAT#13750

Closed
catenacyber wants to merge 2 commits into
OISF:masterfrom
catenacyber:detect-sigmatch-flags-removal-v1
Closed

detect: remove flag SIGMATCH_DEONLY_COMPAT#13750
catenacyber wants to merge 2 commits into
OISF:masterfrom
catenacyber:detect-sigmatch-flags-removal-v1

Conversation

@catenacyber

Copy link
Copy Markdown
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
None, just code clean-up with flag removal

Describe changes:

  • detect: remove flag SIGMATCH_DEONLY_COMPAT
  • detect: remove unused PrefilterStoreGetName

@codecov

codecov Bot commented Aug 26, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.72%. Comparing base (49629f7) to head (53c234c).
⚠️ Report is 28 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #13750       +/-   ##
===========================================
+ Coverage   77.16%   83.72%    +6.56%     
===========================================
  Files         945     1011       +66     
  Lines      172228   275059   +102831     
===========================================
+ Hits       132906   230306    +97400     
- Misses      39322    44753     +5431     
Flag Coverage Δ
fuzzcorpus 62.94% <100.00%> (+<0.01%) ⬆️
livemode 19.00% <100.00%> (+<0.01%) ⬆️
pcap 44.71% <100.00%> (+0.03%) ⬆️
suricata-verify 65.08% <100.00%> (+0.01%) ⬆️
unittests 59.18% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suricata-qa

Copy link
Copy Markdown

Information: QA ran without warnings.

Pipeline = 27234

This was referenced Aug 31, 2025

@inashivb inashivb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@catenacyber

Copy link
Copy Markdown
Contributor Author

new version in #13811

@catenacyber catenacyber closed this Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants