fix(statefulset): survive nil reconciler result instead of panicking#1754
Open
SAY-5 wants to merge 1 commit intoOT-CONTAINER-KIT:mainfrom
Open
fix(statefulset): survive nil reconciler result instead of panicking#1754SAY-5 wants to merge 1 commit intoOT-CONTAINER-KIT:mainfrom
SAY-5 wants to merge 1 commit intoOT-CONTAINER-KIT:mainfrom
Conversation
Reconcile unconditionally type-asserted the reconciler result as *appsv1.StatefulSet. reconciler.Reconcile can return (nil, err) when the downstream Create/Update failed, so the assertion panicked with 'interface conversion: client.Object is nil, not *v1.StatefulSet' and crashlooped the operator whenever the sentinel StatefulSet update path hit a transient error. Every subsequent reconcile repeated the panic, and managed StatefulSets lost their labels while operator pods cycled in CrashLoopBackOff. Fall back to the expected StatefulSet and propagate err when the reconciler returned nil (or a non-StatefulSet) so the controller receives a valid value alongside the error and schedules a requeue instead of taking down the whole worker. Refs OT-CONTAINER-KIT/redis-operator issue 1753. Signed-off-by: SAY-5 <say.apm35@gmail.com>
SAY-5
requested review from
drivebyer,
iamabhishek-dubey and
shubham-cmyk
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1753.
Problem
statefulset.Reconcileunconditionally type-asserted the reconciler result as*appsv1.StatefulSet:reconciler.Reconcilecan return(nil, err)when the underlying Create/Update failed, so the assertion panicked:This crashlooped the operator pod every reconcile cycle on
RedisReplicationCRs with an embedded sentinel (redis-sStatefulSet), and the managed StatefulSets lost their labels entirely.Fix
Fall back to the expected StatefulSet and propagate
errwhen the reconciler returnednil(or a non-StatefulSet), so the controller receives a valid value alongside the error and schedules a requeue instead of taking down the whole worker.Test
go build ./internal/controller/common/statefulset/...clean; no existing tests in that package.