Skip to content

fix(statefulset): survive nil reconciler result instead of panicking #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(statefulset): survive nil reconciler result instead of panicking #1754

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion internal/controller/common/statefulset/statefulset_reconcile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,20 @@ func Reconcile(ctx context.Context, k8sClient client.Client, expected appsv1.Sta
update(&expected, existed.(*appsv1.StatefulSet))
},
})
return *reconciled.(*appsv1.StatefulSet), err
// reconciler.Reconcile can return (nil, err) when the downstream
// Create/Update failed; the previous unconditional type assertion
// panicked the reconciler with 'interface conversion: client.Object
// is nil, not *v1.StatefulSet' and crash-looped the operator. Fall
// back to the expected object so the controller receives a valid
// StatefulSet alongside the error and schedules a requeue.
if err != nil || reconciled == nil {
return expected, err
}
sts, ok := reconciled.(*appsv1.StatefulSet)
if !ok || sts == nil {
return expected, err
}
return *sts, err
}

func needUpdate(expected, existed *appsv1.StatefulSet) bool {
Expand Down