Skip to content

[VT Server]: Allow responses to messages which do not require a connection with a client#611

Merged
martonmiklos merged 1 commit intomainfrom
adrian/vt-server-better-connectionless-responses
Mar 27, 2026
Merged

[VT Server]: Allow responses to messages which do not require a connection with a client#611
martonmiklos merged 1 commit intomainfrom
adrian/vt-server-better-connectionless-responses

Conversation

@ad3154
Copy link
Copy Markdown
Member

@ad3154 ad3154 commented Oct 1, 2025

Describe your changes

Sometimes a VT client might request certain information from a VT server before it identifies itself as a working set master, and sometimes an external service tool might want to query some details from a VT, so, this allows more messages to be responded to by the VT server without a connection from a client.

This will probably improve compatibility with some VT clients.

Specifically, we now allow the following messages from non-clients, or from clients earlier in the connection process.

  • Get Memory
  • Get Number of Soft Keys
  • Get Text Font Data Message
  • Get Hardware
  • Get Supported Widechars
  • Get Window Mask Data

The diff for this one is going to be large unfortunately... but basically all I did was move the messages into two different functions.

How has this been tested?

I have not yet had the chance to test it in our VT, but intend to test it shortly with #607

@ad3154 ad3154 requested review from GwnDaan and martonmiklos October 1, 2025 00:22
@ad3154 ad3154 self-assigned this Oct 1, 2025
@ad3154 ad3154 added the iso: virtual terminal Related to the ISO-11783:7 standard label Oct 1, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 1, 2025

martonmiklos
martonmiklos previously approved these changes Nov 3, 2025
Copy link
Copy Markdown
Contributor

@martonmiklos martonmiklos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martonmiklos
Copy link
Copy Markdown
Contributor

FYI I came across an implement which likely failed to load due to this:
kép

Unfortunately I have not managed to test with the updated stack as it was at the very end of the Agritechnica :(

@sonarqubecloud
Copy link
Copy Markdown

1 similar comment
@sonarqubecloud
Copy link
Copy Markdown

@martonmiklos
Copy link
Copy Markdown
Contributor

@ad3154
I would recommend to go forward with this one, as it could help in some cases with the VT. What do you think?

@gtorretta123
Copy link
Copy Markdown

I'll keep an eye on the merge into main. Is there a development build available in the meantime?

@ad3154
Copy link
Copy Markdown
Member Author

ad3154 commented Mar 26, 2026

I'm fine with merging it in, it just doesn't have much testing

… working set master separately

Sometimes a VT client might request certain information from a VT server
before it identifies itself as a working set master, and sometimes
an external service tool might want to query some details from a VT,
so, this allows more messages to be responded to by the VT server
without a connection from a client.
@ad3154 ad3154 force-pushed the adrian/vt-server-better-connectionless-responses branch from 2797b49 to ed026d3 Compare March 26, 2026 22:54
@ad3154
Copy link
Copy Markdown
Member Author

ad3154 commented Mar 27, 2026

@martonmiklos I rebased it.. if you approve it we can merge it.

Copy link
Copy Markdown
Contributor

@martonmiklos martonmiklos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martonmiklos martonmiklos merged commit c073258 into main Mar 27, 2026
10 checks passed
@martonmiklos martonmiklos deleted the adrian/vt-server-better-connectionless-responses branch March 27, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

iso: virtual terminal Related to the ISO-11783:7 standard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants