Comment out ASR.stop() and add TODO#2547
Merged
openminddev merged 2 commits intomainfrom Apr 22, 2026
Merged
Conversation
In src/inputs/plugins/google_asr.py, the shutdown logic that called self.asr.stop() has been commented out and replaced with a TODO note. The TODO suggests considering sending the TTS status multiple times to the ASR provider to ensure it receives the interrupt signal (particularly when mode switches occur during TTS playback). The original stop() call is left commented for reference so the behavior can be revisited when a more robust interrupt strategy is implemented.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the shutdown behavior of the Google ASR input plugin by disabling the direct ASRProvider.stop() call and leaving a TODO note about implementing a more robust interrupt mechanism during TTS/mode transitions.
Changes:
- Commented out the
self.asr.stop()shutdown logic inGoogleASRInput.stop(). - Added a TODO comment describing a potential future approach for improving interrupt reliability.
Update a comment in GoogleASRInput changing 'Todo:' to 'TODO:' to follow conventional TODO formatting. This is a non-functional change for code clarity and consistency.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In src/inputs/plugins/google_asr.py, the shutdown logic that called self.asr.stop() has been commented out and replaced with a TODO note. The TODO suggests considering sending the TTS status multiple times to the ASR provider to ensure it receives the interrupt signal (particularly when mode switches occur during TTS playback). The original stop() call is left commented for reference so the behavior can be revisited when a more robust interrupt strategy is implemented.