Skip to content

Comment out ASR.stop() and add TODO #2547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openminddev merged 2 commits into from
Apr 22, 2026
+10 −6
Merged

Comment out ASR.stop() and add TODO #2547

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fdf463
Comment out ASR.stop() and add TODO
openminddev Apr 22, 2026
a41025a
Standardize TODO comment in google_asr.py
openminddev Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/inputs/plugins/google_asr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,9 +340,13 @@ def stop(self):
except Exception as e:
logging.warning(f"Failed to close Zenoh ASR session: {e}")

if self.asr:
try:
self.asr.stop()
logging.info("ASR provider stopped")
except Exception as e:
logging.warning(f"Failed to stop ASR provider: {e}")
# Todo:
Comment thread
openminddev marked this conversation as resolved.
Outdated
# Consider sending the TTS status multiple times to ASR provider to ensure that
# the ASR provider properly receives the interrupt signal,
# especially in cases where the mode switch happens during TTS playback
# if self.asr:
# try:
# self.asr.stop()
# logging.info("ASR provider stopped")
# except Exception as e:
# logging.warning(f"Failed to stop ASR provider: {e}")
Comment thread
openminddev marked this conversation as resolved.
Outdated
Loading