Skip to content

[BugFix] Fix legacy logger propagation leaking unformatted logs to stderr #7617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gongweibao wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[BugFix] Fix legacy logger propagation leaking unformatted logs to stderr #7617

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5affe4b
[BugFix] Fix legacy logger propagation leaking unformatted logs to st…
gongweibao Apr 24, 2026
6d94496
fix some
gongweibao Apr 27, 2026
62427d5
fix some
gongweibao Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions fastdeploy/logger/logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,7 @@ def get_trace_logger(self, name, file_name, without_formater=False, print_to_con
logger.addHandler(console_handler)
console_handler.propagate = False
Comment thread
gongweibao marked this conversation as resolved.
Outdated

# Set propagate (maintain original logic)
# logger.propagate = False
logger.propagate = False

return logger

Expand Down Expand Up @@ -311,8 +310,7 @@ def _get_legacy_logger(self, name, file_name, without_formater=False, print_to_c
logger.addHandler(console_handler)
console_handler.propagate = False
Comment thread
gongweibao marked this conversation as resolved.
Outdated

# Set propagate (maintain original logic)
# logger.propagate = False
logger.propagate = False

return logger

Expand Down
2 changes: 1 addition & 1 deletion tests/logger/test_logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def test_legacy_logger_creation(self):
def test_logger_propagate(self):
"""Test log propagation settings"""
legacy_logger = self.logger._get_legacy_logger("test", "test.log")
self.assertTrue(legacy_logger.propagate)
self.assertFalse(legacy_logger.propagate)
Comment thread
gongweibao marked this conversation as resolved.

def test_get_trace_logger_basic(self):
"""Test basic functionality of get_trace_logger"""
Expand Down
Loading