another note#1168
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR strengthens deprecation notices in the Prefect 3.x gotchas list and adds a missing CLI deprecation for prefect deployment build.
- Changed wording to emphasize that
Deployment.build_from_flow()is fully removed. - Added a new bullet for the CLI deprecation of
prefect deployment build.
Comment on lines
+78
to
+79
| "Deployment.build_from_flow() IS COMPLETELY REMOVED IN 3.x, use some_flow.from_source(...).deploy(...) instead.", | ||
| "`prefect deployment build ...` IS COMPLETELY REMOVED IN 3.x, use `prefect deploy ...` instead", |
There was a problem hiding this comment.
[nitpick] The all-caps emphasis is inconsistent with the sentence casing used in other bullets. Consider using sentence case for consistency (e.g., "is completely removed in 3.x").
Suggested change
| "Deployment.build_from_flow() IS COMPLETELY REMOVED IN 3.x, use some_flow.from_source(...).deploy(...) instead.", | |
| "`prefect deployment build ...` IS COMPLETELY REMOVED IN 3.x, use `prefect deploy ...` instead", | |
| "Deployment.build_from_flow() is completely removed in 3.x, use some_flow.from_source(...).deploy(...) instead.", | |
| "`prefect deployment build ...` is completely removed in 3.x, use `prefect deploy ...` instead", |
| "prefect 3.x uses pydantic 2 and server data from prefect 2.x is not compatible with 3.x", | ||
| "Deployment.build_from_flow() is removed in 3.x, use some_flow.from_source(...).deploy(...) instead.", | ||
| "Deployment.build_from_flow() IS COMPLETELY REMOVED IN 3.x, use some_flow.from_source(...).deploy(...) instead.", | ||
| "`prefect deployment build ...` IS COMPLETELY REMOVED IN 3.x, use `prefect deploy ...` instead", |
There was a problem hiding this comment.
[nitpick] There are two spaces before IS COMPLETELY REMOVED, and the sentence lacks a trailing period. Use single spacing and add a period to match other entries.
Suggested change
| "`prefect deployment build ...` IS COMPLETELY REMOVED IN 3.x, use `prefect deploy ...` instead", | |
| "`prefect deployment build ...` IS COMPLETELY REMOVED IN 3.x, use `prefect deploy ...` instead.", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.