Skip to content

another note #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzstoatzz merged 1 commit into from
Jun 9, 2025
Merged

another note #1168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/slackbot/src/slackbot/search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ def review_common_3x_gotchas() -> list[str]:
"futures must be resolved by passing them to another task, returning them or manually calling .result() or .wait()",
"agents are replaced by workers in prefect 3.x, work pools replace the infra blocks from prefect.infrastructure",
"prefect 3.x uses pydantic 2 and server data from prefect 2.x is not compatible with 3.x",
"Deployment.build_from_flow() is removed in 3.x, use some_flow.from_source(...).deploy(...) instead.",
"Deployment.build_from_flow() IS COMPLETELY REMOVED IN 3.x, use some_flow.from_source(...).deploy(...) instead.",
"`prefect deployment build ...` IS COMPLETELY REMOVED IN 3.x, use `prefect deploy ...` instead",
Comment on lines +78 to +79

Copilot AI Jun 9, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The all-caps emphasis is inconsistent with the sentence casing used in other bullets. Consider using sentence case for consistency (e.g., "is completely removed in 3.x").

Suggested change
"Deployment.build_from_flow() IS COMPLETELY REMOVED IN 3.x, use some_flow.from_source(...).deploy(...) instead.",
"`prefect deployment build ...` IS COMPLETELY REMOVED IN 3.x, use `prefect deploy ...` instead",
"Deployment.build_from_flow() is completely removed in 3.x, use some_flow.from_source(...).deploy(...) instead.",
"`prefect deployment build ...` is completely removed in 3.x, use `prefect deploy ...` instead",

Copilot uses AI. Check for mistakes.

Copilot AI Jun 9, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] There are two spaces before IS COMPLETELY REMOVED, and the sentence lacks a trailing period. Use single spacing and add a period to match other entries.

Suggested change
"`prefect deployment build ...` IS COMPLETELY REMOVED IN 3.x, use `prefect deploy ...` instead",
"`prefect deployment build ...` IS COMPLETELY REMOVED IN 3.x, use `prefect deploy ...` instead.",

Copilot uses AI. Check for mistakes.
"Workers (f.k.a. agents) poll for scheduled runs, whereas task workers are websocket clients that executed backgrounded task runs",
"To avoid interactivity in the Prefect CLI, use the TOP LEVEL --no-prompt flag, e.g. `prefect --no-prompt deploy ...`",
]
Expand Down